If rendering has failed due to a net.OpError stop rendering (attempt 2) #19049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately go-gitea#18642 does not work because a `*net.OpError` does not implement the `Is` interface to make `errors.Is` work correctly - thus leading to the irritating conclusion that a `*net.OpError` is not a `*net.OpError`. Here we keep the `errors.Is` because presumably this will be fixed at some point in the golang main source code but also we add a simply type cast to also check. Fix go-gitea#18629 Signed-off-by: Andrew Thornton <art27@cantab.net>
|
Here's a simple test case: package main
import (
"errors"
"fmt"
"net"
)
func main() {
opError := &net.OpError{Op: "write", Net: "", Err: fmt.Errorf("random")}
fmt.Println(opError)
fmt.Println(errors.Is(opError, &net.OpError{}))
}a |
GiteaBot
added
the
lgtm/need 2
noerw
approved these changes
Mar 10, 2022
GiteaBot
added
lgtm/need 1
Gusted
reviewed
Mar 10, 2022
| @@ -269,7 +269,7 @@ func (ctx *Context) ServerError(logMsg string, logErr error) { | |||
| func (ctx *Context) serverErrorInternal(logMsg string, logErr error) { | |||
| if logErr != nil { | |||
| log.ErrorWithSkip(2, "%s: %v", logMsg, logErr) | |||
| if errors.Is(logErr, &net.OpError{}) { | |||
| if _, ok := logErr.(*net.OpError); ok || errors.Is(logErr, &net.OpError{}) { | |||
There was a problem hiding this comment.
Would it be possible to add a test case for this?
There was a problem hiding this comment.
If I could have easily reproduced the problem I would have resolved this issue the first time and known that the original solution didn't work.
Gusted
approved these changes
Mar 10, 2022
GiteaBot
added
lgtm/done
|
make lgtm work |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Mar 10, 2022
…2) (go-gitea#19049) Backport go-gitea#19049 Unfortunately go-gitea#18642 does not work because a `*net.OpError` does not implement the `Is` interface to make `errors.Is` work correctly - thus leading to the irritating conclusion that a `*net.OpError` is not a `*net.OpError`. Here we keep the `errors.Is` because presumably this will be fixed at some point in the golang main source code but also we add a simply type cast to also check. Fix go-gitea#18629 Signed-off-by: Andrew Thornton <art27@cantab.net>
6543
pushed a commit
that referenced
this pull request
Mar 10, 2022
…2) (#19049) (#19056) Backport #19049 Unfortunately #18642 does not work because a `*net.OpError` does not implement the `Is` interface to make `errors.Is` work correctly - thus leading to the irritating conclusion that a `*net.OpError` is not a `*net.OpError`. Here we keep the `errors.Is` because presumably this will be fixed at some point in the golang main source code but also we add a simply type cast to also check. Fix #18629 Signed-off-by: Andrew Thornton <art27@cantab.net>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 11, 2022
* giteaofficial/main: Prevent 500 when there is an error during new auth source post (go-gitea#19041) Update the webauthn_credential_id_sequence in Postgres (go-gitea#19048) If rendering has failed due to a net.OpError stop rendering (attempt 2) (go-gitea#19049) use xorm builder for models.getReviewers() (go-gitea#19033) RSS/Atom support for Orgs (go-gitea#17714) Fix flag validation (go-gitea#19046) Improve SyncMirrors logging (go-gitea#19045)
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
…2) (go-gitea#19049) Unfortunately go-gitea#18642 does not work because a `*net.OpError` does not implement the `Is` interface to make `errors.Is` work correctly - thus leading to the irritating conclusion that a `*net.OpError` is not a `*net.OpError`. Here we keep the `errors.Is` because presumably this will be fixed at some point in the golang main source code but also we add a simply type cast to also check. Fix go-gitea#18629 Signed-off-by: Andrew Thornton <art27@cantab.net>
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately #18642 does not work because a
*net.OpErrordoes not implementthe
Isinterface to makeerrors.Iswork correctly - thus leading to theirritating conclusion that a
*net.OpErroris not a*net.OpError.Here we keep the
errors.Isbecause presumably this will be fixed atsome point in the golang main source code but also we add a simply type
cast to also check.
Fix #18629
Signed-off-by: Andrew Thornton art27@cantab.net