Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

If rendering has failed due to a net.OpError stop rendering (attempt 2) #19049

Merged
merged 3 commits into from
Mar 10, 2022
Merged

If rendering has failed due to a net.OpError stop rendering (attempt 2) #19049

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e353bf8
If rendering has failed due to a net.OpError stop rendering (attempt 2)
zeripath Mar 10, 2022
7f93300
Merge branch 'main' into refix-18629-net.OpError-is-not-a-net.OpError
zeripath Mar 10, 2022
f4632ad
Merge branch 'main' into refix-18629-net.OpError-is-not-a-net.OpError
zeripath Mar 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/context/context.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ func (ctx *Context) ServerError(logMsg string, logErr error) {
func (ctx *Context) serverErrorInternal(logMsg string, logErr error) {
if logErr != nil {
log.ErrorWithSkip(2, "%s: %v", logMsg, logErr)
if errors.Is(logErr, &net.OpError{}) {
if _, ok := logErr.(*net.OpError); ok || errors.Is(logErr, &net.OpError{}) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to add a test case for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I could have easily reproduced the problem I would have resolved this issue the first time and known that the original solution didn't work.

// This is an error within the underlying connection
// and further rendering will not work so just return
return
Expand Down