Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Change webhook-type in create-view #29114

Merged
merged 8 commits into from
Feb 15, 2024
Merged

Change webhook-type in create-view #29114

merged 8 commits into from
Feb 15, 2024

Conversation

zokkis
Copy link
Contributor

@zokkis zokkis commented Feb 9, 2024

It's now possible to change webhook-type in create-view.

before:
image

after:
image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 9, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 9, 2024
@zokkis zokkis changed the title enhancement: Change webhook-type in create-view Change webhook-type in create-view Feb 10, 2024
@silverwind
Copy link
Member

silverwind commented Feb 11, 2024 •
edited
Loading

Pushed some styling fixes and fixed the regression with the SVGs. We need to render the matrix icon as <svg>, because only with that the color will be changed to white on dark theme because if fill: currentcolor.

I also removed the Class option because we can easily vertically center with flexbox from the parent instead and because vertical-align: middleshould not be used for vertical centering because it does not work in all cases.

silverwind
silverwind approved these changes Feb 11, 2024 •
edited
Loading
View reviewed changes
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 11, 2024
@zokkis
Copy link
Contributor Author

zokkis commented Feb 11, 2024

Pushed some styling fixes and fixed the regression with the SVGs. We need to render the matrix icon as <svg>, because only with that the color will be changed to white on dark theme because if fill: currentcolor.

I also removed the Class option because we can easily vertically center with flexbox from the parent instead and because vertical-align: middleshould not be used for vertical centering because it does not work in all cases.

Ok thanks, I only have one question

Why is there always a magic-number for margin/padding
29718cc#diff-bf3a284bc2ea51adf0333a1ece388b60b4aff10e3ec715a889c6fed44450f2d3R420

@silverwind
Copy link
Member

silverwind commented Feb 14, 2024 •
edited
Loading

Why is there always a magic-number for margin/padding
29718cc#diff-bf3a284bc2ea51adf0333a1ece388b60b4aff10e3ec715a889c6fed44450f2d3R420

It's a inherited value from the fomantic-ui dependency. They have some calculations ongoing and a lot of their margin/padding etc are based on these Sass calculations:

https://github.com/fomantic/Fomantic-UI/blob/6daf34d16395f8aa9b964719095c775fc8e4e95b/src/themes/default/globals/site.variables#L219

11 / 14 = 0.785714285714286

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 14, 2024
@KN4CK3R KN4CK3R added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 15, 2024
@silverwind silverwind merged commit 374e886 into go-gitea:main Feb 15, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Feb 15, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 15, 2024
@delvh delvh added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Feb 15, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 16, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
1688a0c 
* giteaofficial/main: (23 commits)
  Remove jQuery from SSH key form parser (go-gitea#29193)
  Refactor request function (go-gitea#29187)
  Docker Tag Information in Docs (go-gitea#29047)
  Fix gitea-action user avatar broken on edited menu (go-gitea#29190)
  Disable parallel Make execution (go-gitea#29186)
  Auto-update the system status in admin dashboard (go-gitea#29163)
  Avoid vue warning in dev mode (go-gitea#29188)
  Update JS and PY dependencies (go-gitea#29184)
  [skip ci] Updated translations via Crowdin
  Implement contributors graph (go-gitea#27882)
  Add support for action artifact serve direct (go-gitea#29120)
  Advertise WebAuthn support (go-gitea#29176)
  Tweak repo header (go-gitea#29134)
  Change webhook-type in create-view (go-gitea#29114)
  Remove jQuery from the comment task list (go-gitea#29170)
  Fix can not select team reviewers when reviewers is empty (go-gitea#29174)
  move # labels to be above inputs (go-gitea#28753)
  Refactor locale&string&template related code (go-gitea#29165)
  Extract linguist code to method (go-gitea#29168)
  bump to use go 1.22 (go-gitea#29119)
  ...
@zokkis zokkis deleted the enhancement/change-webhook-type-on-create branch February 17, 2024 01:07
silverwind added a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@zokkis @silverwind @GiteaBot
Change webhook-type in create-view (go-gitea#29114)
c428a4f 
It's now possible to change webhook-type in create-view.

before:

![image](https://github.com/go-gitea/gitea/assets/72873130/9ee1b9fb-843b-4f28-b8d6-6361e5d184f1)

after:

![image](https://github.com/go-gitea/gitea/assets/72873130/9dbf058f-5912-43af-9acd-487271212f2d)

---------

Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: Giteabot <teabot@gitea.io>
6543 pushed a commit to 6543-forks/gitea that referenced this pull request Feb 26, 2024
@zokkis @earl-warren
Change webhook-type in create-view (go-gitea#29114)
7263b3e 
It's now possible to change webhook-type in create-view.

before:

![image](https://github.com/go-gitea/gitea/assets/72873130/9ee1b9fb-843b-4f28-b8d6-6361e5d184f1)

after:

![image](https://github.com/go-gitea/gitea/assets/72873130/9dbf058f-5912-43af-9acd-487271212f2d)

---------

Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: Giteabot <teabot@gitea.io>
(cherry picked from commit 374e886)

Conflicts:
	templates/repo/settings/webhook/base_list.tmpl
	templates/shared/webhook/icon.tmpl
@github-actions GitHub Actions
Copy link

Automatically locked because of our CONTRIBUTING guidelines

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
@wxiaoguang
Copy link
Contributor

Maybe a regression, invalid link:

image

@go-gitea go-gitea unlocked this conversation Mar 9, 2024
@wxiaoguang wxiaoguang mentioned this pull request Mar 10, 2024
Closed
@wxiaoguang
Copy link
Contributor

Opened a new issue to track: Incorrect menu/link on webhook edit page #29699

@silverwind silverwind mentioned this pull request Mar 13, 2024
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@silverwind silverwind silverwind approved these changes

@a1012112796 a1012112796 a1012112796 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
7 participants
@zokkis @silverwind @wxiaoguang @a1012112796 @KN4CK3R @GiteaBot @delvh