Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Tweak repo header #29134

Merged
merged 5 commits into from
Feb 15, 2024
Merged

Tweak repo header #29134

merged 5 commits into from
Feb 15, 2024

Conversation

silverwind
Copy link
Member

  • Tweak colors, remove link color from repo name and make text use inherited color
  • Downsize repo icon from 32px to 24px

Before:
Screenshot 2024-02-11 at 15 31 00

After:
Screenshot 2024-02-11 at 15 30 48

@silverwind
Tweak repo header
7cbf0b2 
- Tweak colors, remove link color from repo name and make text use
  inherited color
- Downsize repo icon from 32px to 24px
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 11, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 11, 2024
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Feb 11, 2024
@silverwind silverwind added the type/enhancement An improvement of existing functionality label Feb 11, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 11, 2024
@techknowlogick
Copy link
Member

I know GH doesn't emphasize that the repo name is a link, but I feel like this downplays an important aspect of the page. I guess this isn't exactly the title/h1 of the page though.

That being said, these are feelings that aren't backed by any usability data, so I won't block. Just wanted to register my thoughts.

@denyskon
Copy link
Member

I don't want for the page to become more and more greyscale 😅

I like the primary color as a way to highlight links, but I won't block if it gets enough approvals.

silverwind and others added 2 commits February 13, 2024 23:36
@silverwind @wxiaoguang
Update templates/repo/header.tmpl
53f8993 
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@silverwind @wxiaoguang
Update templates/repo/header.tmpl
504938b 
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@silverwind
Copy link
Member Author

I think I prefer either both user and repo colored (like in 1.21), or none (like here). I do think we can increase the font size on the header a bit more to emphasize it. It was 21px on 1.21, now is 16px. Maybe 20px to match github's repo frontpage. In the navbar, they have 14px.

@silverwind
Copy link
Member Author

silverwind commented Feb 13, 2024 •
edited
Loading

Here's with 18px now. Also tried 20px but it looked too large.

image

Could revert back to color, but I don't really like it, it does look "cleaner" without.

image

@techknowlogick
Copy link
Member

@silverwind thanks for adjusting. The new screenshot without colour is a +1 from me :)

wxiaoguang
wxiaoguang approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with that it doesn't need to be that colorful.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 14, 2024
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 15, 2024
@silverwind
Copy link
Member Author

Merging as there are no strong objections.

@silverwind silverwind enabled auto-merge (squash) February 15, 2024 16:27
@silverwind silverwind merged commit 363b5f0 into go-gitea:main Feb 15, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Feb 15, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 15, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 16, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
1688a0c 
* giteaofficial/main: (23 commits)
  Remove jQuery from SSH key form parser (go-gitea#29193)
  Refactor request function (go-gitea#29187)
  Docker Tag Information in Docs (go-gitea#29047)
  Fix gitea-action user avatar broken on edited menu (go-gitea#29190)
  Disable parallel Make execution (go-gitea#29186)
  Auto-update the system status in admin dashboard (go-gitea#29163)
  Avoid vue warning in dev mode (go-gitea#29188)
  Update JS and PY dependencies (go-gitea#29184)
  [skip ci] Updated translations via Crowdin
  Implement contributors graph (go-gitea#27882)
  Add support for action artifact serve direct (go-gitea#29120)
  Advertise WebAuthn support (go-gitea#29176)
  Tweak repo header (go-gitea#29134)
  Change webhook-type in create-view (go-gitea#29114)
  Remove jQuery from the comment task list (go-gitea#29170)
  Fix can not select team reviewers when reviewers is empty (go-gitea#29174)
  move # labels to be above inputs (go-gitea#28753)
  Refactor locale&string&template related code (go-gitea#29165)
  Extract linguist code to method (go-gitea#29168)
  bump to use go 1.22 (go-gitea#29119)
  ...
silverwind added a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@silverwind @wxiaoguang
Tweak repo header (go-gitea#29134)
48aa8f3 
- Tweak colors, remove link color from repo name and make text use
inherited color
- Downsize repo icon from 32px to 24px

Before:
<img width="255" alt="Screenshot 2024-02-11 at 15 31 00"
src="https://github.com/go-gitea/gitea/assets/115237/f65c1d02-d8a3-4171-ad3d-4c95871fb2ba">

After:
<img width="260" alt="Screenshot 2024-02-11 at 15 30 48"
src="https://github.com/go-gitea/gitea/assets/115237/a9b25b56-8d3f-4910-af60-2513d44f6d81">

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
6543 pushed a commit to 6543-forks/gitea that referenced this pull request Feb 26, 2024
@silverwind @earl-warren
Tweak repo header (go-gitea#29134)
7474f62 
- Tweak colors, remove link color from repo name and make text use
inherited color
- Downsize repo icon from 32px to 24px

Before:
<img width="255" alt="Screenshot 2024-02-11 at 15 31 00"
src="https://github.com/go-gitea/gitea/assets/115237/f65c1d02-d8a3-4171-ad3d-4c95871fb2ba">

After:
<img width="260" alt="Screenshot 2024-02-11 at 15 30 48"
src="https://github.com/go-gitea/gitea/assets/115237/a9b25b56-8d3f-4910-af60-2513d44f6d81">

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
(cherry picked from commit 363b5f0)
@github-actions GitHub Actions
Copy link

Automatically locked because of our CONTRIBUTING guidelines

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
6 participants
@silverwind @techknowlogick @denyskon @wxiaoguang @delvh @GiteaBot