Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Do not escape relative path in RPM primary index #32038

Merged
merged 5 commits into from
Sep 16, 2024
Merged

Do not escape relative path in RPM primary index #32038

merged 5 commits into from
Sep 16, 2024

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Sep 13, 2024

Fixes #32021

Do not escape the relative path.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 13, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 13, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Sep 13, 2024
delvh
delvh approved these changes Sep 14, 2024
View reviewed changes
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, it sounds weird not to escape things, but if it is actually intended…
Oh well.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 14, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 14, 2024
@lunny lunny added backport/v1.22 This PR should be backported to Gitea 1.22 reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Sep 14, 2024
@GiteaBot GiteaBot added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Sep 14, 2024
@lunny lunny enabled auto-merge (squash) September 16, 2024 20:30
@lunny lunny merged commit f528df9 into go-gitea:main Sep 16, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Sep 16, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Sep 16, 2024
@KN4CK3R @GiteaBot
Do not escape relative path in RPM primary index (go-gitea#32038)
866a6df 
Fixes go-gitea#32021

Do not escape the relative path.
@GiteaBot GiteaBot mentioned this pull request Sep 16, 2024
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Sep 16, 2024
lunny pushed a commit that referenced this pull request Sep 17, 2024
@GiteaBot @KN4CK3R
Do not escape relative path in RPM primary index (#32038) (#32054)
8a39a48 
Backport #32038 by @KN4CK3R

Fixes #32021

Do not escape the relative path.

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
@KN4CK3R KN4CK3R deleted the fix-rpm-escape-32021 branch September 17, 2024 06:02
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 18, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
5a0b68b 
* giteaofficial/main:
  Add missing comment reply handling (go-gitea#32050)
  Fix CI (go-gitea#32062)
  Lazy load avatar images (go-gitea#32051)
  Included tag search capabilities (go-gitea#32045)
  Do not escape relative path in RPM primary index (go-gitea#32038)
  feat(go-gitea#31666): Set the columns height to hug all its contents (go-gitea#31726)
  [skip ci] Updated translations via Crowdin
  [skip ci] Updated translations via Crowdin
  Use a common message template instead of a special one (go-gitea#31878)
  Check if the `due_date` is nil when editing issues (go-gitea#32035)
@yp05327 yp05327 modified the milestones: 1.24.0, 1.23.0 Sep 19, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 15, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/packages type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

RPM Registry: primary.xml <location> should not url encode caret (^) characters
5 participants
@KN4CK3R @lunny @delvh @yp05327 @GiteaBot