Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Lazy load avatar images #32051

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Lazy load avatar images #32051

merged 3 commits into from
Sep 17, 2024

Conversation

hiifong
Copy link
Member

@hiifong hiifong commented Sep 16, 2024

Before:

before.mp4

After:

after.mp4

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 16, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 16, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Sep 16, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 16, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 16, 2024
@lunny lunny added the backport/v1.22 This PR should be backported to Gitea 1.22 label Sep 16, 2024
@yp05327 yp05327 changed the title set avatar image to lazy loading Lazy load avatar images Sep 17, 2024
@yp05327 yp05327 added reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. performance/speed performance issues with slow downs labels Sep 17, 2024
@techknowlogick techknowlogick enabled auto-merge (squash) September 17, 2024 18:03
@techknowlogick techknowlogick merged commit f38e101 into go-gitea:main Sep 17, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Sep 17, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Sep 17, 2024
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Sep 17, 2024
@hiifong hiifong deleted the lazy branch September 18, 2024 01:02
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 18, 2024
* giteaofficial/main:
  Add missing comment reply handling (go-gitea#32050)
  Fix CI (go-gitea#32062)
  Lazy load avatar images (go-gitea#32051)
  Included tag search capabilities (go-gitea#32045)
  Do not escape relative path in RPM primary index (go-gitea#32038)
  feat(go-gitea#31666): Set the columns height to hug all its contents (go-gitea#31726)
  [skip ci] Updated translations via Crowdin
  [skip ci] Updated translations via Crowdin
  Use a common message template instead of a special one (go-gitea#31878)
  Check if the `due_date` is nil when editing issues (go-gitea#32035)
@yp05327 yp05327 modified the milestones: 1.24.0, 1.23.0 Sep 19, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 16, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code performance/speed performance issues with slow downs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants