Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix issue sidebar regression #32598

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

wxiaoguang
Copy link
Contributor

Regression of #32576

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 21, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 21, 2024
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Nov 21, 2024
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Nov 21, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 21, 2024
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a1012112796 need to be more careful with those closing tags.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 21, 2024
@wxiaoguang wxiaoguang merged commit a32cfb2 into go-gitea:main Nov 21, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Nov 21, 2024
@wxiaoguang wxiaoguang deleted the fix-issue-milestone branch November 21, 2024 16:38
@lunny lunny modified the milestones: 1.24.0, 1.23.0 Nov 21, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 22, 2024
* giteaofficial/main:
  Add line-through for deleted branch on pull request view page (go-gitea#32500)
  Fix issue sidebar regression (go-gitea#32598)
  Fix PR diff review form submit (go-gitea#32596)
  Fix some typescript issues (go-gitea#32586)
  Fix GetInactiveUsers (go-gitea#32540)
  disable gravatar in test (go-gitea#32529)
  Add 'Copy path' button to file view (go-gitea#32584)
  Improve issue sidebar UI (go-gitea#32587)
  Supplement and Improvement for go-gitea#32558 (go-gitea#32585)
  make search box in issue sidebar dropdown list always show when scrolling (go-gitea#32576)
  Fix submodule parsing (go-gitea#32571)
  allow the actions user to login via the jwt token (go-gitea#32527)
  Support HTTP POST requests to `/userinfo`, aligning to OpenID Core specification (go-gitea#32578)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 19, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants