Fix PR diff review form submit #32596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
This was referenced Nov 21, 2024
wxiaoguang
force-pushed
the
fix-pr-diff-review
branch
from
6a41f16 to
8db66ad
Compare
wxiaoguang
commented
Nov 21, 2024
silverwind
reviewed
Nov 21, 2024
yardenshoham
approved these changes
Nov 21, 2024
GiteaBot
added
lgtm/need 1
Co-authored-by: silverwind <me@silverwind.io>
silverwind
reviewed
Nov 21, 2024
Co-authored-by: silverwind <me@silverwind.io>
silverwind
reviewed
Nov 21, 2024
silverwind
reviewed
Nov 21, 2024
Co-authored-by: silverwind <me@silverwind.io>
silverwind
approved these changes
Nov 21, 2024
GiteaBot
added
lgtm/done
silverwind
reviewed
Nov 21, 2024
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 22, 2024
* giteaofficial/main: Add line-through for deleted branch on pull request view page (go-gitea#32500) Fix issue sidebar regression (go-gitea#32598) Fix PR diff review form submit (go-gitea#32596) Fix some typescript issues (go-gitea#32586) Fix GetInactiveUsers (go-gitea#32540) disable gravatar in test (go-gitea#32529) Add 'Copy path' button to file view (go-gitea#32584) Improve issue sidebar UI (go-gitea#32587) Supplement and Improvement for go-gitea#32558 (go-gitea#32585) make search box in issue sidebar dropdown list always show when scrolling (go-gitea#32576) Fix submodule parsing (go-gitea#32571) allow the actions user to login via the jwt token (go-gitea#32527) Support HTTP POST requests to `/userinfo`, aligning to OpenID Core specification (go-gitea#32578)
wxiaoguang
added a commit
that referenced
this pull request
Dec 1, 2024
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #31622.
There is a longstanding bug in #19612, it doesn't handle submit event correctly
This PR also rewrites some jQuery code