Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix JS error when reply comment on Conversation page #32685

Merged
merged 3 commits into from
Dec 1, 2024
Merged

Fix JS error when reply comment on Conversation page #32685

merged 3 commits into from
Dec 1, 2024

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Nov 30, 2024 •
edited
Loading

Fix #32684, regression of #32596

Actually it is a side-effect of jQuery removal: jQuery could tolerate non-existing elements.

And fix another regression bug from #30453 (initCompReactionSelector double-init)

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 30, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 30, 2024
@wxiaoguang wxiaoguang mentioned this pull request Nov 30, 2024
Closed
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 30, 2024
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Nov 30, 2024
@wxiaoguang wxiaoguang changed the title Fix JS error when reply commenton Conversation page Fix JS error when reply comment on Conversation page Nov 30, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 30, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 1, 2024
@wxiaoguang wxiaoguang merged commit 1bb1a51 into go-gitea:main Dec 1, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Dec 1, 2024
@wxiaoguang wxiaoguang deleted the fix-pr-comment branch December 1, 2024 16:14
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 2, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
5ebe735 
* giteaofficial/main:
  Refactor RepoBranchTagSelector (go-gitea#32681)
  Allow to disable the password-based login (sign-in) form (go-gitea#32687)
  Fix JS error when reply comment on Conversation page (go-gitea#32685)
  fix(go-gitea#32667): 🐛 Fixe a keystring misuse and refactor duplicates keystrings (go-gitea#32668)
@wxiaoguang wxiaoguang modified the milestones: 1.24.0, 1.23.0 Dec 2, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 1, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

Error when replying to code comment from "Conversation" tab
4 participants
@wxiaoguang @lunny @delvh @GiteaBot