Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Refactor buttons to use new init framework #33774

Merged
merged 6 commits into from
Mar 3, 2025
Merged

Refactor buttons to use new init framework #33774

merged 6 commits into from
Mar 3, 2025

Conversation

kerwin612
Copy link
Member

@kerwin612 kerwin612 commented Mar 3, 2025 •
edited by wxiaoguang
Loading

Make buttons to use new init framework

  • "js-toggle-commit-body"
  • "show-panel/hide-panel/show-modal"
  • "copy-content"

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 3, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 3, 2025
@wxiaoguang wxiaoguang mentioned this pull request Mar 3, 2025
Closed
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 3, 2025
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Mar 3, 2025
@wxiaoguang wxiaoguang changed the title Refactor initGlobalButtons Using the New registerGlobalSelectorFunc Refactor buttons to use new init framework Mar 3, 2025
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 3, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 3, 2025
@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Mar 3, 2025
@wxiaoguang wxiaoguang added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Mar 3, 2025
@wxiaoguang wxiaoguang mentioned this pull request Mar 3, 2025
Closed
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 3, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 3, 2025
@lunny lunny enabled auto-merge (squash) March 3, 2025 20:20
@lunny lunny merged commit ad204f9 into go-gitea:main Mar 3, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 3, 2025
@kerwin612 kerwin612 deleted the refactor-initglobalbuttons-with-registerglobalselectorfunc branch March 4, 2025 00:06
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 4, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
7657e9d 
* giteaofficial/main:
  Adjust appearence of commit status webhook (go-gitea#33778)
  Refactor initRepoBranchTagSelector to use new init framework (go-gitea#33776)
  Refactor buttons to use new init framework (go-gitea#33774)
  Refactor markup and pdf-viewer to use new init framework (go-gitea#33772)
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/templates This PR modifies the template files size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@kerwin612 @lunny @wxiaoguang @GiteaBot