Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Adjust appearence of commit status webhook #33778

Merged
merged 5 commits into from
Mar 3, 2025
Merged

Adjust appearence of commit status webhook #33778

merged 5 commits into from
Mar 3, 2025

Conversation

denyskon
Copy link
Member

@denyskon denyskon commented Mar 3, 2025

Some visual improvement for the commit status webhook message introduced by #33320

  • use short commit SHA as already done in e. g. commit webhook
  • fix spacing, link text
  • do not set user link for internal gitea-actions user

Before:
grafik

After:
grafik

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 3, 2025
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 3, 2025
@denyskon denyskon requested a review from lunny March 3, 2025 16:39
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Mar 3, 2025
@denyskon denyskon added backport/v1.23 This PR should be backported to Gitea 1.23 type/enhancement An improvement of existing functionality topic/webhooks modifies/go Pull requests that update Go code and removed modifies/go Pull requests that update Go code labels Mar 3, 2025
@denyskon denyskon added this to the 1.24.0 milestone Mar 3, 2025
@denyskon denyskon requested a review from wxiaoguang March 3, 2025 17:43
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 3, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 3, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 3, 2025
@lunny lunny enabled auto-merge (squash) March 3, 2025 20:21
@lunny lunny merged commit ffb2765 into go-gitea:main Mar 3, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 3, 2025
@denyskon denyskon deleted the fix/commit-status-message branch March 3, 2025 21:55
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 4, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
7657e9d 
* giteaofficial/main:
  Adjust appearence of commit status webhook (go-gitea#33778)
  Refactor initRepoBranchTagSelector to use new init framework (go-gitea#33776)
  Refactor buttons to use new init framework (go-gitea#33774)
  Refactor markup and pdf-viewer to use new init framework (go-gitea#33772)
@denyskon
Copy link
Member Author

denyskon commented Mar 4, 2025

@GiteaBot ?

GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Mar 4, 2025
@denyskon @GiteaBot
Adjust appearence of commit status webhook (go-gitea#33778)
2ea1ade 
Some visual improvement for the commit status webhook message introduced
by go-gitea#33320

- use short commit SHA as already done in e. g. commit webhook
- fix spacing, link text
- do not set user link for internal gitea-actions user

Before: 

![grafik](https://github.com/user-attachments/assets/9c460846-c350-444c-89b5-8a0d5e26cb86)

After:

![grafik](https://github.com/user-attachments/assets/05519cd8-6d8f-432b-bd9d-082de558a55a)
@GiteaBot GiteaBot mentioned this pull request Mar 4, 2025
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Mar 4, 2025
lunny pushed a commit that referenced this pull request Mar 4, 2025
@GiteaBot @denyskon
Adjust appearence of commit status webhook (#33778) (#33789)
69d35ee 
Backport #33778 by @denyskon

Some visual improvement for the commit status webhook message introduced
by #33320

- use short commit SHA as already done in e. g. commit webhook
- fix spacing, link text
- do not set user link for internal gitea-actions user

Before: 

![grafik](https://github.com/user-attachments/assets/9c460846-c350-444c-89b5-8a0d5e26cb86)

After:

![grafik](https://github.com/user-attachments/assets/05519cd8-6d8f-432b-bd9d-082de558a55a)

Co-authored-by: Denys Konovalov <kontakt@denyskon.de>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.23 This PR should be backported to Gitea 1.23 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/S Denotes a PR that changes 10-29 lines, ignoring generated files. topic/webhooks type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@denyskon @lunny @wxiaoguang @GiteaBot