Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

When deleting to a new branch we should expect ErrBranchNotExist #9769

Merged
merged 2 commits into from
Jan 14, 2020
Merged

When deleting to a new branch we should expect ErrBranchNotExist #9769

merged 2 commits into from
Jan 14, 2020

Conversation

zeripath
Copy link
Contributor

Fix #9752

@zeripath zeripath added this to the 1.12.0 milestone Jan 14, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 14, 2020
@codecov-io
Copy link

codecov-io commented Jan 14, 2020 •
edited
Loading

Codecov Report

Merging #9769 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9769      +/-   ##
==========================================
+ Coverage   42.32%   42.33%   +0.01%     
==========================================
  Files         600      600              
  Lines       78357    78357              
==========================================
+ Hits        33168    33176       +8     
+ Misses      41134    41123      -11     
- Partials     4055     4058       +3
Impacted Files Coverage Δ
services/pull/temp_repo.go 31.62% <0%> (-2.57%) ⬇️
models/webhook.go 70.46% <0%> (+1.06%) ⬆️
modules/queue/workerpool.go 43.77% <0%> (+2.57%) ⬆️
models/unit.go 67.56% <0%> (+5.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a8559a...6a594be. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 14, 2020
@zeripath zeripath merged commit d171cd4 into go-gitea:master Jan 14, 2020
@zeripath zeripath deleted the fix-9752-DeleteRepoFile branch January 14, 2020 23:11
6543 pushed a commit to 6543-forks/gitea that referenced this pull request Jan 14, 2020
@zeripath @6543
Fix go-gitea#9752 (go-gitea#9769)
8acfa2e
@6543 6543 mentioned this pull request Jan 14, 2020
Merged
@sapk sapk added the backport/done All backports for this PR have been created label Jan 14, 2020
sapk pushed a commit that referenced this pull request Jan 15, 2020
@6543 @zeripath @sapk
Fix #9752 (#9769) (#9775)
602c5da 
Co-authored-by: zeripath <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@sapk sapk sapk approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

DeleteRepoFile incorrectly handles Delete to new branch
5 participants
@zeripath @codecov-io @sapk @6543 @GiteaBot