Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

DeleteRepoFile incorrectly handles Delete to new branch (#9769) #9775

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Jan 14, 2020

Backport #9769

@6543
Copy link
Member Author

6543 commented Jan 14, 2020

ping @zeripath @sapk

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 14, 2020
@sapk sapk added the type/bug label Jan 14, 2020
@sapk sapk added this to the 1.11.0 milestone Jan 14, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 14, 2020
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such an amazingly elegant fix. However did you think of it... 😛

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 14, 2020
@sapk sapk merged commit 602c5da into go-gitea:release/v1.11 Jan 15, 2020
@6543 6543 deleted the backport_9769 branch January 15, 2020 00:43
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants