Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CLI flag --storage-directory seems not to work #980

Closed
Weav3r opened this issue Sep 16, 2024 · 2 comments · Fixed by #981
Closed

CLI flag --storage-directory seems not to work #980

Weav3r opened this issue Sep 16, 2024 · 2 comments · Fixed by #981
Labels
type:bug Something isn't working

Comments

@Weav3r
Copy link

Weav3r commented Sep 16, 2024

Data

  • Shiori version: Shiori version 1.7.0 (build 650f192)
  • Database Engine: SQLite
  • Operating system: Linux (Arch)
  • CLI/Web interface/Web Extension: CLI

Describe the bug / actual behavior

The --storage-directory flag seems not to work or maybe I'm just running the wrong command. This is not a major issue but if you'd find the time to comment on this I'd be grateful. Thanks for this amazing app.

Expected behavior

Expected that ~/data will be used to store db and files (thumbs and archive)

To Reproduce

Steps to reproduce the behavior:

  1. Go to pwd of shiori
  2. Run command ./shiori server --storage-directory '~/data'
  3. Data is stored in ~/.local/share/shiori

Screenshots

If applicable, add screenshots to help explain your problem.

Notes

Add any other context about the problem here.

@Monirzadeh
Copy link
Collaborator

Thanks for the bug report, I sent a PR to fix this.

@Weav3r
Copy link
Author

Weav3r commented Sep 16, 2024

Noted. Thanks for the quick response.

@github-project-automation github-project-automation bot moved this from To do to Done in Roadmap Sep 22, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
type:bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants