fix: --storage-directory flag not being honored in the CLI #981

Monirzadeh · 2024-09-16T13:38:09Z

fix #980
i don't see anywhere else we set cfg.Storage.DataDir if it has higher priority than --storage-directory than we should change

if storageDirectory != "" && cfg.Storage.DataDir != ""

to

if storageDirectory != "" && cfg.Storage.DataDir == ""

Closes #980

fmartingr

Thanks for taking care of the fix 🥳

respect --storage-directory flag fix go-shiori#980

8e2aa20

Monirzadeh requested a review from fmartingr September 16, 2024 13:38

Monirzadeh self-assigned this Sep 16, 2024

fmartingr approved these changes Sep 22, 2024

View reviewed changes

fmartingr changed the title ~~fix: storage-directory change storage directory now~~ fix: --storage-directory flag not being honored in the CLI Sep 22, 2024

Merge branch 'master' into fix-storage-directory-flag

3d5ab19

fmartingr merged commit 9492075 into go-shiori:master Sep 22, 2024
9 checks passed

Monirzadeh deleted the fix-storage-directory-flag branch September 22, 2024 16:34

Monirzadeh mentioned this pull request Sep 23, 2024

fix: make number of concurrent downloads configurable #972

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: --storage-directory flag not being honored in the CLI #981

fix: --storage-directory flag not being honored in the CLI #981

Monirzadeh commented Sep 16, 2024 •

edited by fmartingr

Loading

fmartingr left a comment

fix: --storage-directory flag not being honored in the CLI #981

fix: --storage-directory flag not being honored in the CLI #981

Conversation

Monirzadeh commented Sep 16, 2024 • edited by fmartingr Loading

fmartingr left a comment

Choose a reason for hiding this comment

Monirzadeh commented Sep 16, 2024 •

edited by fmartingr

Loading