Add location ranges to output

[sim642]

Closes #428.

This is based on goblint/cil#51.

TODO

• Add extra locations to functions for just the name/declaration. Not currently needed.
• Fix opam pin after Add end locations to statements cil#51 is merged.

[sim642]

Currently for testing purposes I made CilType.Location.show fail if the end location is missing in order to easily find all constructs where it was still missing. I will undo that now, but it did reveal two interesting cases.

12/01 containment/analyse

Crashes with

Option warning: Without thread escape analysis, every local variable whose address is taken is considered escaped, i.e., global!
Unimplemented: joinLoc LLVM INTERNAL:1:1--1:-1 regression.h:5:1--1:-1

Apparently that old C++ -> C converter produced some crazy location info where a function beginning is in one filename and the end is in another. There's no sensible way to construct such location range.

So far I haven't seen any other case where such insanity happens, so maybe we can just ignore it and it'll be fixed after we remove the contain analysis from "lean" Goblint.

EDIT: I've now just skipped it, so this doesn't have to wait for "fat" Goblint release.

24/08 octagon/previously_problematic_f

Crashes with

[Warning][Integer > Overflow][CWE-190] Signed integer overflow ([Error][Unknown] About to crash! (Fatal error: exception Failure("no end at initfun:0:0")

The output is wacky because the exception happens when printing the location of the previous message, but in essence the non-apron octagon analysis uses IntDomain internally and in its computations performs operations which would be an overflow (despite the program itself not having one). And this doesn't happen during some transfer functions, but lattice operations like join, which is the reason for the weird initfun:0:0 location.

[sim642]

I now adapted this to goblint/cil#51 (comment) as well. The just expression locations for ifs are now used for the Test edges in the CFG, instead of the location spanning the entire if. This way warnings about the expression are nice and local.

EDIT: Additionally had to add secondary location ranges to primitive instructions as well since they may be temporary statements inserted by CIL to perform calls and assignments that are part of a conditional expression originally. Those should also have the location on the expression itself, not the entire if.