Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Categorize exp options #516

Merged
merged 12 commits into from
Jan 8, 2022
Merged

Categorize exp options #516

merged 12 commits into from
Jan 8, 2022

Conversation

michael-schwarz
Copy link
Member

@michael-schwarz michael-schwarz commented Jan 3, 2022 •
edited by sim642
Loading

As a part of #28, we decided we want to somewhat cleanup our options:

  • Move witness options from exp.witness.* to witness.*
  • Move solver options from exp.solver.* to solvers.*

What other option should be moved out of exp?

I could, e.g., see:

  • moving exp.malloc.fail and exp.failing_locks to sem
  • moving exp.malloc.wrappers to ana.malloc.wrappers
  • moving exp.partition-arrays.* to ana.base.partition-arrays
  • moving exp.structs.*to ana.base.structs.*
  • moving exp.privatization to ana.base.privatization
  • moving exp.apron.privatization to ana.apron.privatization
  • moving exp.apron.priv.* to ana.apron.priv.*

WDYT?

@michael-schwarz michael-schwarz added the cleanup Refactoring, clean-up label Jan 3, 2022
@sim642 sim642 self-requested a review January 5, 2022 08:21
@sim642
Copy link
Member

sim642 commented Jan 7, 2022

Regarding all the others you've listed, I think they all sound good! I think if we do all of them it's already a big enough batch of option renames for this PR.

@sim642 sim642 added this to the v2.0.0 milestone Jan 7, 2022
@michael-schwarz michael-schwarz marked this pull request as ready for review January 7, 2022 16:01
sim642
sim642 approved these changes Jan 8, 2022
View reviewed changes
@michael-schwarz michael-schwarz merged commit 6bc2e79 into master Jan 8, 2022
@michael-schwarz michael-schwarz deleted the categorize_exp_options branch January 8, 2022 13:20
vogler added a commit to goblint/bench that referenced this pull request Jan 13, 2022
@vogler
renamed goblint options in parallel-run.sh
fa7f1e9 
goblint/analyzer#516
#12
sim642 added a commit to sim642/opam-repository that referenced this pull request Aug 18, 2022
@sim642
[new release] goblint (2.0.0)
6efdfdf 
CHANGES:

Goblint "lean" release after a lot of cleanup.

* Remove unmaintained analyses: OSEK, ARINC, shapes, containment, deadlocksByRaces (goblint/analyzer#460, goblint/analyzer#736, goblint/analyzer#812, goblint/analyzer#474).
* Add interactive analysis (goblint/analyzer#391).
* Add server mode (goblint/analyzer#522).
* Add Compilation Database support (goblint/analyzer#406, goblint/analyzer#448).
* Add floating point domain, unrolled array domain and improved struct domains (goblint/analyzer#734, goblint/analyzer#761, goblint/analyzer#577, goblint/analyzer#419).
* Add static loop unrolling and heap variable unrolling (goblint/analyzer#563, goblint/analyzer#722).
* Improve race detection with may-happen-in-parallel analysis (goblint/analyzer#529, goblint/analyzer#518, goblint/analyzer#595).
* Reimplement lockset and deadlock analyses (goblint/analyzer#659, goblint/analyzer#662, goblint/analyzer#650, goblint/analyzer#655).
* Add pthread extraction to Promela (goblint/analyzer#220).
* Add location spans to output (goblint/analyzer#428, goblint/analyzer#449).
* Improve race reporting (goblint/analyzer#550, goblint/analyzer#551).
* Improve dead code reporting (goblint/analyzer#94, goblint/analyzer#353, goblint/analyzer#785).
* Refactor warnings (goblint/analyzer#55, goblint/analyzer#783).
* Add JSON schema for configuration (goblint/analyzer#476, goblint/analyzer#499).
* Refactor option names (goblint/analyzer#28, goblint/analyzer#192, goblint/analyzer#516, goblint/analyzer#675).
* Add bash completion (goblint/analyzer#669).
* Add OCaml 4.13 and 4.14 support, remove OCaml 4.09 support (goblint/analyzer#503, goblint/analyzer#672).
@sim642 sim642 mentioned this pull request Aug 18, 2022
Merged
sim642 added a commit to sim642/opam-repository that referenced this pull request Aug 18, 2022
@sim642
[new release] goblint (2.0.0)
1c281d5 
CHANGES:

Goblint "lean" release after a lot of cleanup.

* Remove unmaintained analyses: OSEK, ARINC, shapes, containment, deadlocksByRaces (goblint/analyzer#460, goblint/analyzer#736, goblint/analyzer#812, goblint/analyzer#474).
* Add interactive analysis (goblint/analyzer#391).
* Add server mode (goblint/analyzer#522).
* Add Compilation Database support (goblint/analyzer#406, goblint/analyzer#448).
* Add floating point domain, unrolled array domain and improved struct domains (goblint/analyzer#734, goblint/analyzer#761, goblint/analyzer#577, goblint/analyzer#419).
* Add static loop unrolling and heap variable unrolling (goblint/analyzer#563, goblint/analyzer#722).
* Improve race detection with may-happen-in-parallel analysis (goblint/analyzer#529, goblint/analyzer#518, goblint/analyzer#595).
* Reimplement lockset and deadlock analyses (goblint/analyzer#659, goblint/analyzer#662, goblint/analyzer#650, goblint/analyzer#655).
* Add pthread extraction to Promela (goblint/analyzer#220).
* Add location spans to output (goblint/analyzer#428, goblint/analyzer#449).
* Improve race reporting (goblint/analyzer#550, goblint/analyzer#551).
* Improve dead code reporting (goblint/analyzer#94, goblint/analyzer#353, goblint/analyzer#785).
* Refactor warnings (goblint/analyzer#55, goblint/analyzer#783).
* Add JSON schema for configuration (goblint/analyzer#476, goblint/analyzer#499).
* Refactor option names (goblint/analyzer#28, goblint/analyzer#192, goblint/analyzer#516, goblint/analyzer#675).
* Add bash completion (goblint/analyzer#669).
* Add OCaml 4.13 and 4.14 support, remove OCaml 4.09 support (goblint/analyzer#503, goblint/analyzer#672).
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sim642 sim642 sim642 approved these changes

Assignees
No one assigned
Labels
cleanup Refactoring, clean-up
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@michael-schwarz @sim642