Update CI/CD builder image #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
James-Mart
added
the
no-log
swatanabe
reviewed
Jan 11, 2024
.github/workflows/ubuntu-builder.yml
Outdated
| @@ -11,9 +11,9 @@ jobs: | |||
| fail-fast: false | |||
| matrix: | |||
| include: | |||
| - builder-image: "ghcr.io/${{ github.repository_owner }}/psibase-builder-ubuntu-2004:9e5daca8d7a08cf877ac4c40a9d3c12cdb44e534" | |||
| - builder-image: "ghcr.io/${{ github.repository_owner }}/psibase-builder-ubuntu-2004:f202fea25d15c43afc8361551313e981ce2a5f87" | |||
There was a problem hiding this comment.
I can't figure out what this image is. I can see it in the packages list, but there's no such revision in the image-builders repo.
There was a problem hiding this comment.
Good catch, this made me realize artifacts are being uploaded on PR, instead of just on merge.
There was a problem hiding this comment.
I ended up reworking the CI/CD logic in the image-builders repo. See this PR.
James-Mart
force-pushed
the
update-builder-image
branch
from
44e4015 to
a37e05c
Compare
James-Mart
force-pushed
the
update-builder-image
branch
from
a37e05c to
e934171
Compare
|
I updated the version here to one that is tied to an actual commit ID in the builders repo. |
Merged
swatanabe
approved these changes
Feb 20, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.