Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add component parser #595

Merged
merged 6 commits into from
Feb 21, 2024
Merged

add component parser #595

merged 6 commits into from
Feb 21, 2024

Conversation

James-Mart
Copy link
Member

This is a stripped-down version of the graph component that simply parses components into component objects and wit files.
It should be able to be transpiled using jco into either a core wasm or js in order to use it in the browser.

@James-Mart James-Mart requested a review from Velua February 19, 2024 20:18
@James-Mart James-Mart marked this pull request as ready for review February 19, 2024 20:18
@James-Mart
Copy link
Member Author

This CI/CD build should succeed if we re-trigger it after this PR gets merged.

@James-Mart
Copy link
Member Author

James-Mart commented Feb 20, 2024

This CI/CD build should succeed if we re-trigger it after this PR gets merged.

It was merged, retriggering CI/CD now.

Still seems to be getting the same error:

error: no such command: `component`
View all installed commands with `cargo --list`

But the latest builder image has cargo component installed. Therefore I believe for CI/CD to pass here we will need another merge of the latest main into the dev/plugins branch, and then a merge of dev/plugins into dev/wit-parsing.

My recommendation is that PR reviewers verify the build locally and we merge this one without requiring a passing CI/CD.

@Velua Velua merged commit ddb604d into dev/wit-parsing Feb 21, 2024
1 of 3 checks passed
@Velua Velua deleted the add-component-parser branch February 21, 2024 04:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants