Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

No SBOM logic between SBOM deleted and literally no SBOM generation should be the same #20529

Closed
zyyw opened this issue May 31, 2024 · 2 comments · Fixed by #20533
Closed

No SBOM logic between SBOM deleted and literally no SBOM generation should be the same #20529

zyyw opened this issue May 31, 2024 · 2 comments · Fixed by #20533

Comments

@zyyw
Copy link
Contributor

zyyw commented May 31, 2024

How to reproduce?

  1. deploy a harbor instance with the latest source code
  2. replicate redis:latest from dockerhub to harbor
  3. select all artifacts of the redis artifacts replicated, and click GENERATE SBOM
  4. delete the first SBOM generated
  5. the No SBOM between SBOM deleted and literally no SBOM generation is not the same regarding layout and hover message
Screenshot 2024-05-31 at 4 16 48 PM
@zyyw
Copy link
Contributor Author

zyyw commented May 31, 2024

This might be due to red rectangle having sbom_overview of something like below:

  "sbom_overview": {
    "duration": 16,
    "end_time": "2024-05-31T08:11:23.000Z",
    "scan_status": "Success",
    "start_time": "2024-05-31T08:11:06.808Z"
  }

@stonezdj
Copy link
Contributor

stonezdj commented Jun 1, 2024

this issue #20320 requires the sbom_overview to return a status to stop refresh

stonezdj added a commit to stonezdj/harbor that referenced this issue Jun 3, 2024
fixes goharbor#20529

Signed-off-by: stonezdj <stone.zhang@broadcom.com>
stonezdj added a commit to stonezdj/harbor that referenced this issue Jun 3, 2024
fixes goharbor#20529

Signed-off-by: stonezdj <stone.zhang@broadcom.com>
stonezdj added a commit to stonezdj/harbor that referenced this issue Jun 3, 2024
fixes goharbor#20529

Signed-off-by: stonezdj <stone.zhang@broadcom.com>
stonezdj added a commit to stonezdj/harbor that referenced this issue Jun 3, 2024
fixes goharbor#20529

Signed-off-by: stonezdj <stone.zhang@broadcom.com>
stonezdj added a commit to stonezdj/harbor that referenced this issue Jun 3, 2024
fixes goharbor#20529

Signed-off-by: stonezdj <stone.zhang@broadcom.com>
stonezdj added a commit to stonezdj/harbor that referenced this issue Jun 3, 2024
fixes goharbor#20529

Signed-off-by: stonezdj <stone.zhang@broadcom.com>
zyyw pushed a commit that referenced this issue Jun 3, 2024
No sbom_overview when sbom is deleted

fixes #20529

Signed-off-by: stonezdj <stone.zhang@broadcom.com>
zyyw pushed a commit that referenced this issue Jun 3, 2024
fixes #20529

Signed-off-by: stonezdj <stone.zhang@broadcom.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants