Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

No sbom_overview when sbom is deleted #20533

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Jun 3, 2024

fixes #20529

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner June 3, 2024 02:40
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.22%. Comparing base (b7b8847) to head (070dffa).
Report is 208 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20533      +/-   ##
==========================================
- Coverage   67.56%   66.22%   -1.34%     
==========================================
  Files         991     1045      +54     
  Lines      109181   113491    +4310     
  Branches     2719     2844     +125     
==========================================
+ Hits        73768    75161    +1393     
- Misses      31449    34221    +2772     
- Partials     3964     4109     +145     
Flag Coverage Δ
unittests 66.22% <100.00%> (-1.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/server/v2.0/handler/assembler/report.go 50.64% <100.00%> (ø)

... and 572 files with indirect coverage changes

@stonezdj stonezdj force-pushed the 24jun3_no_status branch from a560553 to 810994f Compare June 3, 2024 04:22
fixes goharbor#20529

Signed-off-by: stonezdj <stone.zhang@broadcom.com>
@stonezdj stonezdj force-pushed the 24jun3_no_status branch from 810994f to 070dffa Compare June 3, 2024 04:51
Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zyyw zyyw merged commit 74f4a35 into goharbor:main Jun 3, 2024
11 of 12 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No SBOM logic between SBOM deleted and literally no SBOM generation should be the same
6 participants