Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Convert the string "0" to number 0 #19080

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Aug 2, 2023

  1. Fixes Retention Policy Not Working When Configured via Harbor User Interface #19046
    Convert the string "0" to the number 0 for the tag retention rules
    Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #19080 (7937cf1) into main (d347752) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head 7937cf1 differs from pull request most recent head be7a3f6. Consider uploading reports for the commit be7a3f6 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19080      +/-   ##
==========================================
- Coverage   67.40%   67.38%   -0.02%     
==========================================
  Files         992      992              
  Lines      108752   108754       +2     
  Branches     2750     2751       +1     
==========================================
- Hits        73300    73289      -11     
- Misses      31519    31532      +13     
  Partials     3933     3933              
Flag Coverage Δ
unittests 67.38% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ation/tag-retention/add-rule/add-rule.component.ts 22.22% <0.00%> (-0.39%) ⬇️

... and 9 files with indirect coverage changes

1. Fixes goharbor#19046

Signed-off-by: AllForNothing <sshijun@vmware.com>
@AllForNothing AllForNothing merged commit 530b782 into goharbor:main Aug 3, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retention Policy Not Working When Configured via Harbor User Interface
6 participants