Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Cherry-pick]Convert the string "0" to number 0 #19082

Merged

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Aug 2, 2023

Cherry-pick #19080

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

1. Fixes goharbor#19046

Signed-off-by: AllForNothing <sshijun@vmware.com>
@AllForNothing AllForNothing requested a review from a team as a code owner August 2, 2023 07:27
@AllForNothing AllForNothing assigned AllForNothing and unassigned chlins Aug 2, 2023
@AllForNothing AllForNothing added the release-note/update Update or Fix label Aug 2, 2023
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #19082 (91ff15a) into release-2.7.0 (e767fe2) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.7.0   #19082      +/-   ##
=================================================
- Coverage          66.39%   66.39%   -0.01%     
=================================================
  Files               1012     1012              
  Lines             108652   108654       +2     
  Branches            2677     2678       +1     
=================================================
- Hits               72144    72142       -2     
- Misses             32543    32548       +5     
+ Partials            3965     3964       -1     
Flag Coverage Δ
unittests 66.39% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ation/tag-retention/add-rule/add-rule.component.ts 22.22% <0.00%> (-0.39%) ⬇️

... and 8 files with indirect coverage changes

@AllForNothing AllForNothing merged commit c1bb162 into goharbor:release-2.7.0 Aug 3, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants