Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add repository read permission to limitedGuest #19757

Merged

Conversation

tpoxa
Copy link
Contributor

@tpoxa tpoxa commented Dec 24, 2023

Fixes #19709

With the #18188 it was forgotten to update the permission on the Limited Guest, so this PR is catching up with that.

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/update"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: Maksym Trofimenko <maksym@container-registry.com>
@tpoxa tpoxa requested a review from a team as a code owner December 24, 2023 12:11
Copy link

codecov bot commented Dec 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f8d2169) 67.55% compared to head (2cfc649) 45.17%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #19757       +/-   ##
===========================================
- Coverage   67.55%   45.17%   -22.38%     
===========================================
  Files         991      244      -747     
  Lines      109165    13332    -95833     
  Branches     2719     2719               
===========================================
- Hits        73746     6023    -67723     
+ Misses      31453     7009    -24444     
+ Partials     3966      300     -3666     
Flag Coverage Δ
unittests 45.17% <ø> (-22.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 750 files with indirect coverage changes

@zyyw
Copy link
Contributor

zyyw commented Dec 26, 2023

@tpoxa are you trying to fix this issue?

If so please also cherry-pick it to release-2.9.0 and release-2.10.0 as well.

@Vad1mo Vad1mo added the release-note/update Update or Fix label Jan 1, 2024
@Vad1mo Vad1mo enabled auto-merge (squash) January 1, 2024 19:10
@zyyw zyyw disabled auto-merge January 2, 2024 08:13
@zyyw zyyw added release-note/update Update or Fix and removed release-note/update Update or Fix labels Jan 2, 2024
@zyyw
Copy link
Contributor

zyyw commented Jan 2, 2024

@tpoxa could you please fix DCO and rebase the main branch?
Thanks

@Vad1mo Vad1mo enabled auto-merge (squash) January 8, 2024 11:05
@Vad1mo Vad1mo merged commit 9e5efc9 into goharbor:main Jan 8, 2024
11 of 12 checks passed
altynbaev pushed a commit to altynbaev/harbor that referenced this pull request Jan 29, 2024
Signed-off-by: Maksym Trofimenko <maksym@container-registry.com>
Co-authored-by: Maksym Trofimenko <maksym@container-registry.com>
Signed-off-by: Altynbaev Dinislam <altynbayevdr@sberautotech.ru>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
release-note/update Update or Fix
Projects
None yet
5 participants