-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
add repository read permission to limitedGuest #19757
Merged
Vad1mo
merged 2 commits into
goharbor:main
from
container-registry:fix/limited-guest-repo-permissions
Jan 8, 2024
Merged
add repository read permission to limitedGuest #19757
Vad1mo
merged 2 commits into
goharbor:main
from
container-registry:fix/limited-guest-repo-permissions
Jan 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maksym Trofimenko <maksym@container-registry.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19757 +/- ##
===========================================
- Coverage 67.55% 45.17% -22.38%
===========================================
Files 991 244 -747
Lines 109165 13332 -95833
Branches 2719 2719
===========================================
- Hits 73746 6023 -67723
+ Misses 31453 7009 -24444
+ Partials 3966 300 -3666
Flags with carried forward coverage won't be shown. Click here to find out more. |
@tpoxa are you trying to fix this issue? If so please also cherry-pick it to |
Vad1mo
approved these changes
Jan 1, 2024
zyyw
approved these changes
Jan 2, 2024
@tpoxa could you please fix |
This was referenced Jan 8, 2024
altynbaev
pushed a commit
to altynbaev/harbor
that referenced
this pull request
Jan 29, 2024
Signed-off-by: Maksym Trofimenko <maksym@container-registry.com> Co-authored-by: Maksym Trofimenko <maksym@container-registry.com> Signed-off-by: Altynbaev Dinislam <altynbayevdr@sberautotech.ru>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19709
With the #18188 it was forgotten to update the permission on the Limited Guest, so this PR is catching up with that.
Please indicate you've done the following: