Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Cherry pick] add repository read permission to limitedGuest #19815

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

tpoxa
Copy link
Contributor

@tpoxa tpoxa commented Jan 8, 2024

Issue being fixed

Fixes #19709

Related to PR #19757

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: Maksym Trofimenko <maksym@container-registry.com>
@tpoxa tpoxa requested a review from a team as a code owner January 8, 2024 18:37
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b622d4a) 67.42% compared to head (83635da) 70.60%.
Report is 2 commits behind head on release-2.9.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.9.0   #19815      +/-   ##
=================================================
+ Coverage          67.42%   70.60%   +3.18%     
=================================================
  Files                993      749     -244     
  Lines             108932    95516   -13416     
  Branches            2752        0    -2752     
=================================================
- Hits               73444    67442    -6002     
+ Misses             31534    24425    -7109     
+ Partials            3954     3649     -305     
Flag Coverage Δ
unittests 70.60% <ø> (+3.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/common/rbac/project/rbac_role.go 70.00% <ø> (ø)

... and 247 files with indirect coverage changes

@Vad1mo Vad1mo added the release-note/update Update or Fix label Jan 9, 2024
@Vad1mo Vad1mo enabled auto-merge (squash) January 9, 2024 10:22
@MinerYang MinerYang assigned zyyw and unassigned MinerYang and stonezdj Jan 15, 2024
@Vad1mo Vad1mo merged commit 8d0c8d4 into goharbor:release-2.9.0 Jan 15, 2024
16 of 17 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants