Skip to content
This repository has been archived by the owner on Jul 5, 2021. It is now read-only.

Demos with empty homepage and/or wrong posts list #682

Closed
onedrawingperday opened this issue Aug 16, 2019 · 148 comments · Fixed by mikeblum/hugo-now#5 or #714
Closed

Demos with empty homepage and/or wrong posts list #682

onedrawingperday opened this issue Aug 16, 2019 · 148 comments · Fixed by mikeblum/hugo-now#5 or #714

Comments

@onedrawingperday
Copy link
Contributor

onedrawingperday commented Aug 16, 2019

Due to the nature of the changes that were introduced in Hugo v.0.57.0 (briefly described in #678 (comment)) a great number of theme demos now display empty homepages and/or post lists that point to section lists (instead of individual posts).

The solution to the problem would be the use of mainSections for theme lists on the homepage (as we have been advocating for a while now) as well the following (or its variations) in list templates:

{{ $pages := .Pages }}
{{ if .IsHome }}
{{ $pages = .Site.RegularPages }}
{{ end }}
{{ $paginator := .Paginate $pages }}

Hugo v.0.58.0 was released on the 4th of September 2019 and the breaking changes to the home.Pages collection that were reverted in 0.57.2 have been re-introduced Theme authors need to issue the fixes described above if they wish to keep their themes listed in the Hugo Showcase.


- Broken themes will be removed around the end of September -

Also note that #668 is in progress and the guidelines for maintaining a theme in the Hugo Showcase are about to change. Theme authors are encouraged to track this issue.

- If you no longer plan to maintain a theme please let us know -

Furthermore there is a related notice in the forum to alert theme authors about the breaking changes.

Below is the full list of affected themes (I have not included the few themes whose authors are working on a fix as mentioned in #678 ):
Midnight theme is affected by another issue and it will be kept in this repo until there is a resolution (even if its demo does not generate)
Hugo Future Imperfect Slim fixed in pacollins/hugo-future-imperfect-slim@afbf3ccb
Yignyang fixed in joway/hugo-theme-yinyang@5091a6c
Hugo Flex fixed in ldeso/hugo-flex@0d64b46
Hugo Lamp fixed in huyb1991/hugo-lamp@b4408fd

  1. Cocoa-EH fix in progress see: hugoThemes #682 mtn/cocoa-eh-hugo-theme#138 @mtn
  2. Dream @g1eny0ung
    Zen fixed in frjo/hugo-theme-zen@a942441
    Bingo fixed in gundamew/hugo-bingo@ea9283f
    OneDly Project fixed in cdeck3r/OneDly-Theme@3302b93
    Alpha Church fixed (see WhiteList a few themes #687 )
    Minimage fixed in dsk52/minimage@959ef80
    Tikva fixed in geschke/hugo-tikva@af5722f
  3. Simple Blox @okabrionz
  4. Hurock @TiTi
    Aether fixed in josephhutch/aether@0cf324b
    Binario fixed in Vimux/Binario@9f5ca76
    Newsprint theme removed in Remove Newsprint Theme #685
    Indigo fixed in AngeloStavrow/indigo@a824342
    eiio fixed in leonhe/hugo_eiio@cc47f86
    Base 16 fixed in htdvisser/hugo-base16-theme@861b48a
    Black & Light fixed in davidhampgonsalves/hugo-black-and-light-theme@4168cd6
  5. Start Bootstrap Clean Blog @UtkarshVerma
    Niello fixed in guangmean/Niello@cc55110
    Massively fixed in Fix homepage issues for Hugo 0.57.0 curtiscde/hugo-theme-massively#72
    Hyde-Hyde fixed as per htr3n/hyde-hyde@ad9701b
    Techlog Simple fixed in mazgi/hugo-theme-techlog-simple@fdf9ccb
    Arabica fixed in nirocfz/arabica@ae66e72
    Ezhil fixed in vividvilla/ezhil@3154483 and vividvilla/ezhil@bb28e76
  6. Yinwang @chinanf-boy
    Inkblotty fixed in tosi29/inkblotty@a2b99bd
    Paper fixed in nanxiaobei/hugo-paper@68a57bb
    Cayman fixed in zwbetz-gh/cayman-hugo-theme@c5c1915
  7. Athena fix in progress see: hugoThemes #682 mtn/athena-hugo-theme#4
    Manis fixed in yursan9/manis-hugo-theme@30ff78a
    Ghostwriter fixed in jbub/ghostwriter@6e9eabc
  8. Hugo Nuo @laozhu
    Even fixed in olOwOlo/hugo-theme-even@5a3e559
  9. Hyde Y @enten
    Air fixed in syui/hugo-theme-air@3bc80b5
    Simplicity fixed in WhiteList a few themes #687
    Beautiful Hugo fixed in halogenica/beautifulhugo@1d75ccd
  10. Changelog Theme @jsnjack
    Dusky Neon Potato fix in VVelox/hugo-dusky-neon-potato@a9bd193
  11. Blackburn @yoshiharuyamashita
    Paper CSS fixed in zwbetz-gh/papercss-hugo-theme@698fe6a
    Hyde fixed see: spf13/hyde@3080504
  12. Zozo @zhoukai620
    Techdoc whitelisted in Whitelist a few themes #691
    Adam & Eve fixed in blankoworld/hugo_theme_adam_eve@e925bcd
    Charaka fixed in natarajmb/charaka-hugo-theme@de01c10
    Hugo Apps Theme fixed in WhiteList a few themes #687
  13. Mondrian @redraw
  14. Spectrum @silvanocerza
    XMin fixed in yihui/hugo-xmin@6123be2
  15. Pickles @mismith0227
  16. Castanet the author replied - (also see 863c677) @mattstratton
  17. Hamburg @hauke96
    Pacman fixed in coderzh/hugo-pacman-theme@ea7d497
  18. Shapez @djuelg
  19. Dream Plus
    Lanyon fixed in tummychow/lanyon-hugo@33ecb36
  20. Hugo NES Classic (notified author in Theme is broken in Hugo v.057.0 rjayasinghe/hugo-nes-classic#2 because it was impossible to tag him here)
    Pixyll fixed in azmelanar/hugo-theme-pixyll@c25f592
    [Minimal Bootstrap Hugo Theme fixed in zwbetz-gh/minimal-bootstrap-hugo-theme@634920a
    Kiss fixed in ribice/kiss@7ea3147
  21. Hugo Bootstrap Premium @appernetic
    Hugo Dusk fixed in gyorb/hugo-dusk@b0d2bc7
    Hugo W3 Simple fixed in jesselau76/hugo-w3-simple@601d63c
  22. Bleach @digivend
    Now UI fixed in cboettig/hugo-now-ui@82c3eb0
    Travelify fixed in balaramadurai/hugo-travelify-theme@65f7a10 - also whitelisted in Whitelist a few themes #691
  23. dockDock @vjeantet
    hugo h5bp fixed in garvincasimir/hugo-h5bp-simple@f6b0f3a
    Herring Cove removed in e736afe
    Hugo Minimalist SPA fixed in Whitelist Hugo Minimalist SPA #683
    Lithium fixed in jrutheiser/hugo-lithium-theme@fba4893
    Beg Unmaintained theme removed in Remove Unmaintained Themes #690
    81. Den fixed in shaform/hugo-theme-den@553b158 - (also see: WhiteList a few themes #687 )
    Robotico whitelisted in Whitelist a few themes #691
  24. Simple Hugo Theme @Xzya
    Silhouette fixed in mattbutton/silhouette-hugo@be305fb
    Octopress fixed in parsiya/Hugo-Octopress@3f80dea
  25. Hugo Bootstrap @Xzya
    Bootstrap BP fixed in spech66/bootstrap-bp-hugo-theme@68314b7
  26. Hugo multi Bootswatch @mpas
    Oldnew Mashup whitelisted in Whitelist a few themes #691
    Er fixed in lingxz/er@ebdb186
    Hugo Grapes fixed in shankar/hugo-grapes@af4af64
    Hugo Classic fixed in goodroot/hugo-classic@bafd650
    Hugo Now fixed in [GH-682] Demos with empty homepage and/or wrong posts list mikeblum/hugo-now#5
    Dark Simplicity fix in kritoke/darksimplicity@e00dc41 and kritoke/darksimplicity@d516015
    Internet Weblog fixed in jnjosh/internet-weblog@2fa06ec
    Simple A fixed in alxschwarz/simple-a@b22f385
  27. Finite @lambdafu
    Rusty theme removed in remove Rusty theme #699
  28. Code Editor @aubm
    Hugo Cards the way this theme was refactored in bul-ikana/hugo-cards@e3248ef is not ideal, so I had to send Add detection of Section Posts in build script #706 to cover this setup in the Build Script.
  29. Phugo @aerohub
    Cocoa unmaintained removed in Remove Cocoa theme #680
    Potato Dark fixed in surajmandalcell/potato-dark@241dea8
  30. AllinOne @orianna-zzo
  31. Basics @arjunkrishnababu96
  32. One @resugary
    Slim fixed in zhe/hugo-theme-slim@f666eff
    BeyondNothing fixed in salcan/BeyondNothing@2931c2a
  33. Martial Paper @pedrodude
  34. Would have been cool in the 80s @pedrodude
  35. Sublime Hugo @dt801ts
  36. Classless @fiatjaf
    Landing Page unmaintained removed in Remove Unmaintained Themes #692
  37. Bootie Docs @progrhyme
    Hugo Frais fixed in the2ne/hugo-frais@cd01972 and the2ne/hugo-frais@056db8f
  38. Tracks @ageekymonk
  39. Phlat @nraboy
    Wave fixed in syui/hugo-theme-wave@68e2aed
    Paperback fixed in dashdashzako/paperback@9b58eba
    onetwothree fixed in Fix homepage for hugo>=0.58.0 schollz/onetwothree#12
  40. Casper @vjeantet
  41. Casper Two @eueung
  42. Simpledoc Theme
    Elephants fixed in meibenny/elephants@7c40d2c
    Reveal JS whitelisted in Whitelist a few themes #691
  43. Luxury Theme
    Gentoo removed in 7fdec13
  44. Retroful Hugo @5ARMALE
  45. Strata - the maintainer is aware
    Liquorice fixed in eliasson/liquorice@4f2af3b
    Hikari fixed in digitalcraftsman/hugo-hikari-theme@314516a
  46. Minimalist - incorrect list - the maintainer is aware
    Journal removed in Remove Journal theme #694
  47. GitHub Project Page @nsomar
  48. Red Lounge @tmaiaroto
  49. Steam - the maintainer is aware
  50. AMP @pdevty
    Light Hugo fixed in tblyler/light-hugo@5ef28a4
  51. Icarus - the maintainer is aware
  52. Hugo Geo @alexurquhart
  53. GoHugo AMP @wildhaber
  54. NeXT @leopku
    Hugo Scroll unmaintained and removed in Remove Unmaintained Themes #692
    Hugo Uno unmaintained and removed in Remove more themes #693
    Hugo Zen unmaintained and removed in Remove more themes #693
  55. Heather Hugo @hbpasti
    Remark Twemoji removed in Remove Unmaintained Themes #690
    Remark Minion removed in Remove Unmaintained Themes #690
    Nixon removed in d46f2d5 also see Demos with empty homepage and/or wrong posts list #682 (comment)
  56. Darkdoc @adejoux
    Twenty Fourteen fixed in jaden/twentyfourteen@89e9097
  57. Angel's Ladder @tanksuzuki
  58. Hugo Bootswatch @nilproductions
  59. Rocktopus @esell
    Gindoro removed in Remove Unmaintained Themes #690
  60. Projecthub
  61. Tachyons @marloncabrera
    Shiori removed in Remove Unmaintained Themes #690
  62. Universal Theme @devcows
@frjo
Copy link

frjo commented Aug 16, 2019

I believe I have fixed https://themes.gohugo.io/hugo-theme-zen/ now.

Thanks for the work keeping the Themes section updated and relevant!

@onedrawingperday
Copy link
Contributor Author

@frjo Thanks the theme demo will be fixed when @digitalcraftsman updates the themes in the repo.

@digitalcraftsman
Copy link
Member

The themes have been updated.

@Vimux
Copy link

Vimux commented Aug 16, 2019

The real impact of Hugo 0.57 breaking changes is even bigger than 155 themes, which stated above.

What about broken taxonomies list pages? As an example, Mainroad. This theme is not listed (because homepage works), but it's affected too. I am sure this is not a complete list of affected themes. I have three themes in themes.gohugo.io and all of them affected somehow: Binario, blank, Mainroad. And worst of all, it was done without notification or any warning.

I'll update my themes ASAP, but probably tomorrow, not today.

@onedrawingperday
Copy link
Contributor Author

onedrawingperday commented Aug 16, 2019

I'll update my themes ASAP, but probably tomorrow, not today.

There is a one month window so take your time.

Also please note that #668 is in progress and I suggest you track it because the guidelines for maintaining a theme in the Hugo Showcase are about to change..

We are a very small team and this is the last time that I spend an exorbitant amount of time running around notifying 155 people.

Thanks.

@curtiscde
Copy link

I've created a fix for the Massively theme and would appreciate a review if anyone has chance:

curtiscde/hugo-theme-massively#72

Thanks

@digitalcraftsman
Copy link
Member

@onedrawingperday we could use Hugo's Twitter account to reach out to theme maintainers. Just let me know how to inform them in 280 characters.

@onedrawingperday
Copy link
Contributor Author

onedrawingperday commented Aug 16, 2019

@digitalcraftsman

If you could tweet the following:

Theme authors you may want to check out https://github.com/gohugoio/hugoThemes/issues/682 to see if your theme is currently broken in Hugo v.057.1

@SamWhited
Copy link

FWIW, and I know I'm probably in the minority here, I do not have a Twitter account. Please also consider using email, or a blog or something I can subscribe to. Alternatively, has anyone considered stabilizing Hugo or at least getting on some sort of release cycle so that theme authors have a chance to fix things before breaking changes are released? Having them just kind of spring up after a release if you're not heavily involved in Hugo development doesn't feel great.

@onedrawingperday
Copy link
Contributor Author

onedrawingperday commented Aug 16, 2019

@digitalcraftsman

Also note that currently I have hit a GitHub limit. It seems that only 50 user mentions are allowed per post. So I cannot notify more people in the first post of this topic and it will not be practical for me to open issues in the different theme repositories or mention them in comments further down.

I have contacted GitHub support for this, hopefully they will do something about it.

So I m giving this a rest until tomorrow.

@digitalcraftsman
Copy link
Member

digitalcraftsman commented Aug 16, 2019

@SamWhited: FWIW, and I know I'm probably in the minority here, I do not have a Twitter account.

Twitter is only an additional channel to reach a wider audience. I think it's more effective and less effort to broadcast this information before contacting the developers individually. Of course we we probably won't reach every developer this way.

@yursan9
Copy link

yursan9 commented Aug 16, 2019

Thank you for your hard work, @onedrawingperday ! I'll fix my theme ASAP

@onedrawingperday
Copy link
Contributor Author

onedrawingperday commented Aug 16, 2019

@SamWhited

We are currently working on #668 and when that issue is resolved, we will put in writing that authors will need to keep an eye on current Hugo developments for making sure that a theme is functional with the latest version.

We always give theme developers a 30 day period for fixing issues and up until now I have been contacting people for problems out of my own time.

Breaking changes of the sort that happened in Hugo 0.57 are rare. Typically there is some kind of deprecation warning but in this case the changes in Pages Collections for the homepage etc. were done at once due to the development of new features like Cascading Front Matter.

@digitalcraftsman
Copy link
Member

digitalcraftsman commented Aug 16, 2019

@SamWhited: Alternatively, has anyone considered stabilizing Hugo or at least getting on some sort of release cycle so that theme authors have a chance to fix things before breaking changes are released?

@bep is the lead developer behind Hugo. He should know best if a stable release cycle can be established and how the roadmap of Hugo will look like (incl. deprecations in future releases.)

To cite him from #678 (comment):

We could probably have dropped this home.Pages change, but since we had to introduce some other related breaking changes, I thought it was better to take all the pain at once ...

@digitalcraftsman
Copy link
Member

@onedrawingperday I just posted a tweet: https://twitter.com/GoHugoIO/status/1162382902937735168

@Leoj03
Copy link

Leoj03 commented Aug 16, 2019

The Universal theme is also suffering from the same issue.
Screenshot_2019-08-16_10-18-05

@SamWhited
Copy link

Twitter is only an additional channel to reach a wider audience. I think it's more effective and less effort to broadcast this information before contacting the developers individually. Of course we we probably won't reach every developer this way.

Yes, contacting each developer individually doesn't seem sustainable. That's why I suggested a mailing list or blog, everyone can use RSS or everyone has an email, but not everyone has a Twitter. Email is universal, so in my mind it's probably the best place to start.

@SamWhited
Copy link

SamWhited commented Aug 16, 2019

This may also just be me, but just from reading the docs on the where page and from this post and the issue, I don't actually understand how to fix my theme. You suggest where site.RegularPages "Type" "in" site.Params.mainSectionsbut that gives me a list of sections (whereas before my blog home page was showing a list of pages). Should I be paginating over all pages in all those sections? Should I still filter on a hardcoded type within those sections? I don't really understand how a blog that before was just displaying pages of type "posts" or some other hardcoded thing can be created using this new mechanism.

@geschke
Copy link

geschke commented Aug 16, 2019

@onedrawingperday Thanks for informing, I'll fix my theme "Tikva" in the next days.

Kind regards,
Ralf

@onedrawingperday
Copy link
Contributor Author

@SamWhited

I will look into your theme and let you know what you need to do in a bit.

onedrawingperday added a commit that referenced this issue Sep 30, 2019
This closes #682

64 themes have been removed and 1 theme was updated.
@onedrawingperday onedrawingperday unpinned this issue Sep 30, 2019
@onedrawingperday
Copy link
Contributor Author

@mattstratton

You are more than welcome to re-submit your theme once it is fixed, as are all the other theme authors.

I have made the commit that closed this issue slightly earlier.

Thanks to all the authors who updated their themes.

RickCogley added a commit to RickCogley/logr.cogley.info that referenced this issue Oct 1, 2019
Thanks @onedrawingperday gohugoio/hugoThemes#682

Signed-off-by: Rick Cogley <rick.cogley@esolia.co.jp>
@g1eny0ung
Copy link

g1eny0ung commented Oct 1, 2019

@onedrawingperday Hi, I have a patch commit early to fixes this problem but I forgot to change the other paginator in layouts/index.html. So the Dream theme is still broken. I am sorry for my carelessness.

The early commit is g1eny0ung/hugo-theme-dream@dbf0c47.

This commit should fix the problem. g1eny0ung/hugo-theme-dream@29cfa53.

If you are free, can you help me see if this solves the problem? Very thanks.

I already test it in my blog https://github.com/g1eny0ung/blog. Seems that all works fine. I re-submit in #717.

@jsnjack
Copy link

jsnjack commented Oct 1, 2019

@onedrawingperday Hi, I have noticed that hugo changelog theme (https://github.com/jsnjack/hugo-changelog-theme) has been removed from the themes page. I have already created a fix and reported it here #682 (comment) Do I need to change something else?

@onedrawingperday
Copy link
Contributor Author

@jsnjack

Your theme was removed because its homepage rendered empty on the Hugo Themes showcase for reasons that are not related to this particular issue. See #718 for the explanation.

Your theme has been re-added with d6f2cf6 once the deployment finishes it will show up again on the website.

ryanfox1985 pushed a commit to devcows/hugo-universal-theme that referenced this issue Oct 29, 2019
In Hugo 0.57.0, a change was made that caused this theme to incorrectly render the recent posts.  More information can be found [here](gohugoio/hugoThemes#682).  This edit should fix that error.  It has been tested on a live site and it works.
dornieden added a commit to dornieden/hugo-theme-casper that referenced this issue Nov 8, 2019
The changes in Hugo v.0.57.0 made this theme not showing posts on the homepage.
See: gohugoio/hugoThemes#682

One line of code fixed this issue in the casper theme and made it work as in previous hugo versions
@onedrawingperday onedrawingperday mentioned this issue Nov 19, 2019
10 tasks
onedrawingperday added a commit that referenced this issue Feb 7, 2020
@gohugoio gohugoio locked as resolved and limited conversation to collaborators May 6, 2020
ocelotsloth pushed a commit to ocelotsloth/hugo-ocelotsloth that referenced this issue Aug 21, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet