Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

build(deps): bump github.com/nunnatsa/ginkgolinter from 0.18.0 to 0.18.3 #5133

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 16, 2024

Bumps github.com/nunnatsa/ginkgolinter from 0.18.0 to 0.18.3.

Release notes

Sourced from github.com/nunnatsa/ginkgolinter's releases.

v0.18.3

What's Changed

Full Changelog: nunnatsa/ginkgolinter@v0.18.2...v0.18.3

v0.18.2

What's Changed

Bug fix: false positive for func returns error func #174

The linter triggers a warning for this case:

func errFunc() func() error {
	return func() error {
		return errors.New("error")
	}
}
var _ = Describe("test if issue 174 was solved", func() {
It("should not trigger", func() {
Eventually(errFunc()).Should(MatchError(ContainSubstring("error")))
})
})

The linter fails to identify the actual value as error value.

Bug Fix: ginkgolinter ignores the Error() method #173

as in:

Expect(func() (int, error) {return 42, nil}()).Error().ToNot(HaveOccurred())

v0.18.1

Bug Fix

Fix #171: A function variable with nil value cannot be asserted with BeNil()

Commits
  • e9f67c0 fix: downgrade min Go
  • 608f078 Fix bug: ginkgolinter ignores the Error() method
  • be3cbdb Bug fix: false positive for func returns error func
  • 7465dc6 sanity: bump golangci-lint to v1.62.0
  • dede785 Bump golang.org/x/tools to v0.27.0
  • ea1fdb9 Fix issue with error function vars
  • 29d6a7d tiny fixes in Readme
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/nunnatsa/ginkgolinter](https://github.com/nunnatsa/ginkgolinter) from 0.18.0 to 0.18.3.
- [Release notes](https://github.com/nunnatsa/ginkgolinter/releases)
- [Commits](nunnatsa/ginkgolinter@v0.18.0...v0.18.3)

---
updated-dependencies:
- dependency-name: github.com/nunnatsa/ginkgolinter
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Relates to an upstream dependency go Pull requests that update Go code labels Nov 16, 2024
@ldez ldez added the linter: update version Update version of linter label Nov 16, 2024
@ldez ldez added this to the next milestone Nov 16, 2024
@ldez ldez self-requested a review November 16, 2024 14:40
@ldez ldez merged commit 9223a69 into master Nov 16, 2024
15 checks passed
@ldez ldez deleted the dependabot/go_modules/github.com/nunnatsa/ginkgolinter-0.18.3 branch November 16, 2024 14:42
@shafeeqes
Copy link

shafeeqes commented Nov 17, 2024

Hi, Do you plan to release any patch for golangci-lint in the near future?
We need this fix in the linter.

@ldez ldez modified the milestones: next, v1.62 Nov 25, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
dependencies Relates to an upstream dependency go Pull requests that update Go code linter: update version Update version of linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants