Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make text computed property handle mixed-parts responses #165

Merged
merged 2 commits into from
May 8, 2024

Conversation

andrewheard
Copy link
Collaborator

@andrewheard andrewheard commented May 8, 2024

  • Added support for responses that include both text and functionCall parts (or other content types in the future).
    • Note: Multiple text parts in a single response is theoretical at this time (may need to revisit the joining approach if the output doesn't match our expectations).
  • Also added a test for parallel function calling (multiple functionCall parts in one response).

See firebase/firebase-js-sdk#8229 for JS (Vertex AI) equivalent.

@github-actions github-actions bot added component:swift sdk Issue/PR related to Swift SDK status:awaiting review PR awaiting review from a maintainer labels May 8, 2024
@andrewheard andrewheard requested a review from paulb777 May 8, 2024 16:27
@andrewheard andrewheard merged commit 7afcf89 into main May 8, 2024
8 checks passed
@andrewheard andrewheard deleted the ah/mixed-content-response branch May 8, 2024 20:32
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label May 8, 2024
enefry added a commit to enefry/generative-ai-swift that referenced this pull request Jun 12, 2024
* commit '54784005b57c2235a7669e0c12e8dafa68f0ca5f':
  Log server error responses without `-GoogleGenerativeAIDebugLogEnabled` (google-gemini#177)
  Send `GenerateContentRequest` in `CountTokensRequest` (google-gemini#175)
  Add `responseSchema` to `GenerationConfig` (google-gemini#176)
  Update models in samples and README to `gemini-1.5-flash-latest` (google-gemini#173)
  Sync UI from VertexAI for Firebase (google-gemini#172)
  Increment SDK version to `0.5.4` (google-gemini#171)
  Add default `RequestOptions.timeout` of 300 seconds (google-gemini#170)
  Delete repo specific Issue Template (google-gemini#169)
  Increment SDK version to `0.5.3` (google-gemini#167)
  Make `text` computed property handle mixed-parts responses (google-gemini#165)
  update doc comments (google-gemini#166)
SsomsakTH pushed a commit to SsomsakTH/generative-ai-swift that referenced this pull request Jun 21, 2024
SsomsakTH pushed a commit to SsomsakTH/generative-ai-swift that referenced this pull request Jun 21, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
component:swift sdk Issue/PR related to Swift SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants