Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

adding the support to custom_property_values webhooks #3207

Closed
hazemarian opened this issue Jul 11, 2024 · 6 comments · Fixed by #3379
Closed

adding the support to custom_property_values webhooks #3207

hazemarian opened this issue Jul 11, 2024 · 6 comments · Fixed by #3379
Assignees

Comments

@hazemarian
Copy link

When there is a webhook event for custom_property_values the pkg will return unknown X-Github-Event in message: custom_property_values

I think adding this for support will be simple

@gmlewis
Copy link
Collaborator

gmlewis commented Jul 11, 2024

Would you like to create a PR for this, @hazemarian, or shall I open this up to other contributors to this repo?

@hazemarian
Copy link
Author

i will take care of it

@gmlewis
Copy link
Collaborator

gmlewis commented Jul 11, 2024

i will take care of it

Great, thank you, @hazemarian! It's yours.

acouvreur added a commit to acouvreur/go-github that referenced this issue Dec 10, 2024
custom_property and custom_property_values events are added.

Closes google#3207
@gmlewis
Copy link
Collaborator

gmlewis commented Dec 10, 2024

@acouvreur - normally, we like to give the original assignee a chance to report on their status before writing a new PR to address an issue assigned to someone else.
However, seeing that you already implemented this, and we haven't heard from @hazemarian for five months, I'll reassign it to you.

EDIT: for some reason, I can't assign it to you, so I've simply unassigned it from @hazemarian .

@acouvreur
Copy link
Contributor

@acouvreur - normally, we like to give the original assignee a chance to report on their status before writing a new PR to address an issue assigned to someone else. However, seeing that you already implemented this, and we haven't heard from @hazemarian for five months, I'll reassign it to you.

EDIT: for some reason, I can't assign it to you, so I've simply unassigned it from @hazemarian .

That make sense, given the time elapsed during the initial issue and now I didn't bother asking if I could implement it.

If this happens again, I'll ask first :)

@gmlewis
Copy link
Collaborator

gmlewis commented Dec 10, 2024

Interesting! TIL that I can only assign a GitHub issue to someone who is either a past contributor or someone who has commented to the actual issue first. I suppose that makes sense, so that I can't just assign issues to random GitHub users.
😄

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants