Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Add custom_property events #3379

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

acouvreur
Copy link
Contributor

custom_property and custom_property_values events are added.

Closes #3207

  • I have run script/fmt.sh
  • I have run script/test.sh
  • I have run script/lint.sh
  • I have run script/generate.sh because changes were detected

custom_property and custom_property_values events are added.

Closes google#3207
Copy link

google-cla bot commented Dec 10, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gmlewis gmlewis changed the title feat: add custom_property events feat: Add custom_property events Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.30%. Comparing base (2b8c7fa) to head (2904eba).
Report is 192 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3379      +/-   ##
==========================================
- Coverage   97.72%   92.30%   -5.42%     
==========================================
  Files         153      176      +23     
  Lines       13390    15031    +1641     
==========================================
+ Hits        13085    13874     +789     
- Misses        215     1064     +849     
- Partials       90       93       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @acouvreur!
One minor tweak, please, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

github/event_types.go Outdated Show resolved Hide resolved
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Dec 10, 2024
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@acouvreur
Copy link
Contributor Author

Thank you, @acouvreur! One minor tweak, please, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

Done!

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @acouvreur !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

Copy link
Contributor

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Dec 10, 2024
@gmlewis
Copy link
Collaborator

gmlewis commented Dec 10, 2024

Thank you, @stevehipwell !
Merging.

@gmlewis gmlewis merged commit f349af0 into google:master Dec 10, 2024
6 of 7 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adding the support to custom_property_values webhooks
3 participants