-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add to Builder methods to Datastore's classes #994
Labels
api: datastore
Issues related to the Datastore API.
Comments
It would be nice to add |
Now I see, it seems more complex than I expected. I am closing this for now. Will reopen in case somebody else feels like those methods should be added. Thanks @ajkannan. |
github-actions bot
pushed a commit
that referenced
this issue
Sep 15, 2022
…ator_java versions (#994) - [ ] Regenerate this pull request now. PiperOrigin-RevId: 472750037 Source-Link: googleapis/googleapis@88f2ea3 Source-Link: https://github.com/googleapis/googleapis-gen/commit/230a5588306aae18fe8f2a57f14d4039ad72c901 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjMwYTU1ODgzMDZhYWUxOGZlOGYyYTU3ZjE0ZDQwMzlhZDcyYzkwMSJ9
github-actions bot
pushed a commit
that referenced
this issue
Oct 4, 2022
…orting to v0.124.13-beta (#994) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-errorreporting](https://github.com/GoogleCloudPlatform/google-cloud-java/tree/master/google-cloud-errorreporting) ([source](https://github.com/GoogleCloudPlatform/google-cloud)) | `0.124.12-beta` -> `0.124.13-beta` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-errorreporting). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMDguMiIsInVwZGF0ZWRJblZlciI6IjMyLjIwOC4yIn0=-->
github-actions bot
pushed a commit
that referenced
this issue
Oct 5, 2022
🤖 I have created a release *beep* *boop* --- ## [3.1.2](https://github.com/googleapis/java-vision/compare/v3.1.1...v3.1.2) (2022-10-03) ### Documentation * Update comments for image annotator OCR models ([#983](https://github.com/googleapis/java-vision/issues/983)) ([5c408fe](https://github.com/googleapis/java-vision/commit/5c408fef37777fb9899d9190b89896318f64d262)) ### Dependencies * Update dependency com.google.cloud:google-cloud-core to v2.8.12 ([#984](https://github.com/googleapis/java-vision/issues/984)) ([59f683c](https://github.com/googleapis/java-vision/commit/59f683ce1933b80a3b6256d9cf7f737c689ba711)) * Update dependency com.google.cloud:google-cloud-core to v2.8.13 ([#992](https://github.com/googleapis/java-vision/issues/992)) ([e0882e8](https://github.com/googleapis/java-vision/commit/e0882e83f338f4fb530a0c304dfa97bc1977fc56)) * Update dependency com.google.cloud:google-cloud-core to v2.8.14 ([#993](https://github.com/googleapis/java-vision/issues/993)) ([efd9c3f](https://github.com/googleapis/java-vision/commit/efd9c3fc7863dd4d819e9628d18bb43998f73ef8)) * Update dependency com.google.cloud:google-cloud-core to v2.8.18 ([#995](https://github.com/googleapis/java-vision/issues/995)) ([ead37cc](https://github.com/googleapis/java-vision/commit/ead37cc0cf1a1af8bb513d89153e30f06ea71f20)) * Update dependency com.google.cloud:google-cloud-core to v2.8.19 ([#1023](https://github.com/googleapis/java-vision/issues/1023)) ([ce23a3b](https://github.com/googleapis/java-vision/commit/ce23a3b2ae1c49a8df71fd66eda38f4845763cad)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#1026](https://github.com/googleapis/java-vision/issues/1026)) ([71a4c70](https://github.com/googleapis/java-vision/commit/71a4c70366ab05af1307d914975aa43a2e5679a7)) * Update dependency com.google.cloud:google-cloud-storage to v2.12.0 ([#986](https://github.com/googleapis/java-vision/issues/986)) ([08262f8](https://github.com/googleapis/java-vision/commit/08262f87c3ce67eed973ccf9fc2f1f63525f5857)) * Update spring.version to v2.7.4 ([#994](https://github.com/googleapis/java-vision/issues/994)) ([8688790](https://github.com/googleapis/java-vision/commit/868879044e4296f524d6157d37b8601a5fc8dc4d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
to yoshi-code-bot/google-cloud-java
that referenced
this issue
Nov 8, 2022
…s#1687) (googleapis#994) * chore(java): add a note in README for migrated split repos Disable renovate bot and flaky bot for split repositories that have moved to the Java monorepo. The Java monorepo will pass the "monorepo=True" parameter to java.common_templates method in its owlbot.py files so that the migration note will not appear in the README in the monorepo. Co-authored-by: Jeff Ching <chingor@google.com> Source-Link: https://github.com/googleapis/synthtool/commit/d4b291604f148cde065838c498bc8aa79b8dc10e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:edae91ccdd2dded2f572ec341a768ad180305a3e8fbfd93064b28e237d35920a
github-actions bot
pushed a commit
that referenced
this issue
Nov 9, 2022
#994) - [ ] Regenerate this pull request now. PiperOrigin-RevId: 485623855 Source-Link: https://github.com/googleapis/googleapis/commit/807125e7953e32535710924fe4bf0362ac93754d Source-Link: https://github.com/googleapis/googleapis-gen/commit/c4ddd6d651da69658a4762c5eafff5cd8f0e25c5 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzRkZGQ2ZDY1MWRhNjk2NThhNDc2MmM1ZWFmZmY1Y2Q4ZjBlMjVjNSJ9
suztomo
pushed a commit
that referenced
this issue
Feb 1, 2023
….6.6 (#994) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.api.grpc:proto-google-iam-v1](https://github.com/googleapis/java-iam/proto-google-iam-v1) ([source](https://github.com/googleapis/java-iam)) | `1.6.4` -> `1.6.6` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-iam</summary> ### [`v1.6.6`](https://github.com/googleapis/java-iam/blob/HEAD/CHANGELOG.md#​166-httpsgithubcomgoogleapisjava-iamcomparev165v166-2022-10-25) [Compare Source](https://github.com/googleapis/java-iam/compare/v1.6.5...v1.6.6) ##### Dependencies - Update dependency com.google.cloud:google-iam-policy to v1.6.5 ([#​489](https://github.com/googleapis/java-iam/issues/489)) ([ab8be40](https://github.com/googleapis/java-iam/commit/ab8be4088259b25799aa5df0e7cfe944a7da7956)) ### [`v1.6.5`](https://github.com/googleapis/java-iam/blob/HEAD/CHANGELOG.md#​165-httpsgithubcomgoogleapisjava-iamcomparev164v165-2022-10-24) [Compare Source](https://github.com/googleapis/java-iam/compare/v1.6.4...v1.6.5) ##### Dependencies - Update dependency com.google.apis:google-api-services-cloudresourcemanager to v3-rev20221016-2.0.0 ([#​479](https://github.com/googleapis/java-iam/issues/479)) ([728084c](https://github.com/googleapis/java-iam/commit/728084cba18609a511dd04d67a59a8b0a4c2a63d)) - Update dependency com.google.auth:google-auth-library-oauth2-http to v1.12.1 ([#​478](https://github.com/googleapis/java-iam/issues/478)) ([94e2ca1](https://github.com/googleapis/java-iam/commit/94e2ca1930ec67bf1d837e044c8a72d64b6eae45)) - Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.5 ([#​486](https://github.com/googleapis/java-iam/issues/486)) ([292042e](https://github.com/googleapis/java-iam/commit/292042ea315d3bff5b07e86b73d82fa290364a8a)) - Update dependency com.google.cloud:google-iam-policy to v1.6.4 ([#​475](https://github.com/googleapis/java-iam/issues/475)) ([b86f46c](https://github.com/googleapis/java-iam/commit/b86f46cd9115b5d07d867766e37d402d054768a2)) - Update dependency com.google.protobuf:protobuf-bom to v3.21.8 ([#​481](https://github.com/googleapis/java-iam/issues/481)) ([cb74130](https://github.com/googleapis/java-iam/commit/cb741301c1add6eb5e790de44caa7961e2ea055d)) - Update dependency com.google.protobuf:protobuf-java to v3.21.8 ([#​482](https://github.com/googleapis/java-iam/issues/482)) ([176de6c](https://github.com/googleapis/java-iam/commit/176de6cb499db8fde987f69df35038d9872fad25)) - Update dependency io.grpc:grpc-protobuf to v1.50.0 ([#​476](https://github.com/googleapis/java-iam/issues/476)) ([358383f](https://github.com/googleapis/java-iam/commit/358383fef13874226454c05464a615651ec5b0fb)) - Update dependency io.grpc:grpc-protobuf to v1.50.2 ([#​483](https://github.com/googleapis/java-iam/issues/483)) ([3c9999b](https://github.com/googleapis/java-iam/commit/3c9999b9b4daca5aa343005ca89055f7172ba2dc)) - Update dependency io.grpc:grpc-stub to v1.50.2 ([#​477](https://github.com/googleapis/java-iam/issues/477)) ([e2255ec](https://github.com/googleapis/java-iam/commit/e2255ecfe43a7aef250802cd1829771d4b3691d8)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yNDEuMTEiLCJ1cGRhdGVkSW5WZXIiOiIzMi4yNDEuMTEifQ==-->
suztomo
pushed a commit
that referenced
this issue
Feb 1, 2023
🤖 I have created a release *beep* *boop* --- ## [2.8.24](https://github.com/googleapis/java-core/compare/v2.8.23...v2.8.24) (2022-10-26) ### Dependencies * Update dependency com.google.api.grpc:proto-google-iam-v1 to v1.6.6 ([#994](https://github.com/googleapis/java-core/issues/994)) ([6bda7ce](https://github.com/googleapis/java-core/commit/6bda7ce63b19eb44add041482edd1e3de1100cad)) * Update dependency com.google.code.gson:gson to v2.10 ([#995](https://github.com/googleapis/java-core/issues/995)) ([0244ed8](https://github.com/googleapis/java-core/commit/0244ed8813ba261f416014cf1eff7a267de23013)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Datastore's
ProjectionEntity
,IncompleteKey
,Entity
andKey
have static builder methods:In other modules we use a
toBuilder()
instance method to create builders from entity objects. Should we usetoBuilder()
also in Datastore? Or is there a reason to prefer staticbuilder(ResourceType copyFrom)
? \cc @ajkannan @aozarovThe text was updated successfully, but these errors were encountered: