Fix deleted topic name #1023
Merged
Fix deleted topic name #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
mziccard
added a commit
to mziccard/gcloud-java
that referenced
this pull request
Jun 27, 2016
github-actions bot
pushed a commit
that referenced
this pull request
Aug 16, 2022
…-plugin to v3.4.1 (#1023) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.maven.plugins:maven-javadoc-plugin](https://maven.apache.org/plugins/) ([source](https://github.com/apache/maven-javadoc-plugin)) | `3.4.0` -> `3.4.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-aiplatform). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNjEuMCIsInVwZGF0ZWRJblZlciI6IjMyLjE2MS4wIn0=-->
github-actions bot
pushed a commit
that referenced
this pull request
Oct 4, 2022
…#1023) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-core](https://github.com/googleapis/java-core) | `2.8.18` -> `2.8.19` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-core</summary> ### [`v2.8.19`](https://github.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#​2819-httpsgithubcomgoogleapisjava-corecomparev2818v2819-2022-09-30) [Compare Source](https://github.com/googleapis/java-core/compare/v2.8.18...v2.8.19) ##### Dependencies - Update dependency com.google.api.grpc:proto-google-common-protos to v2.9.5 ([#​963](https://github.com/googleapis/java-core/issues/963)) ([1ee2f9a](https://github.com/googleapis/java-core/commit/1ee2f9acd3968b21974a550b6732fe68b18085f4)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-vision). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMDguMiIsInVwZGF0ZWRJblZlciI6IjMyLjIwOC4yIn0=-->
github-actions bot
pushed a commit
that referenced
this pull request
Oct 4, 2022
](https://renovatebot.com){kind=link}
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
that referenced
this pull request
Oct 5, 2022
🤖 I have created a release *beep* *boop* --- ## [3.1.2](https://github.com/googleapis/java-vision/compare/v3.1.1...v3.1.2) (2022-10-03) ### Documentation * Update comments for image annotator OCR models ([#983](https://github.com/googleapis/java-vision/issues/983)) ([5c408fe](https://github.com/googleapis/java-vision/commit/5c408fef37777fb9899d9190b89896318f64d262)) ### Dependencies * Update dependency com.google.cloud:google-cloud-core to v2.8.12 ([#984](https://github.com/googleapis/java-vision/issues/984)) ([59f683c](https://github.com/googleapis/java-vision/commit/59f683ce1933b80a3b6256d9cf7f737c689ba711)) * Update dependency com.google.cloud:google-cloud-core to v2.8.13 ([#992](https://github.com/googleapis/java-vision/issues/992)) ([e0882e8](https://github.com/googleapis/java-vision/commit/e0882e83f338f4fb530a0c304dfa97bc1977fc56)) * Update dependency com.google.cloud:google-cloud-core to v2.8.14 ([#993](https://github.com/googleapis/java-vision/issues/993)) ([efd9c3f](https://github.com/googleapis/java-vision/commit/efd9c3fc7863dd4d819e9628d18bb43998f73ef8)) * Update dependency com.google.cloud:google-cloud-core to v2.8.18 ([#995](https://github.com/googleapis/java-vision/issues/995)) ([ead37cc](https://github.com/googleapis/java-vision/commit/ead37cc0cf1a1af8bb513d89153e30f06ea71f20)) * Update dependency com.google.cloud:google-cloud-core to v2.8.19 ([#1023](https://github.com/googleapis/java-vision/issues/1023)) ([ce23a3b](https://github.com/googleapis/java-vision/commit/ce23a3b2ae1c49a8df71fd66eda38f4845763cad)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#1026](https://github.com/googleapis/java-vision/issues/1026)) ([71a4c70](https://github.com/googleapis/java-vision/commit/71a4c70366ab05af1307d914975aa43a2e5679a7)) * Update dependency com.google.cloud:google-cloud-storage to v2.12.0 ([#986](https://github.com/googleapis/java-vision/issues/986)) ([08262f8](https://github.com/googleapis/java-vision/commit/08262f87c3ce67eed973ccf9fc2f1f63525f5857)) * Update spring.version to v2.7.4 ([#994](https://github.com/googleapis/java-vision/issues/994)) ([8688790](https://github.com/googleapis/java-vision/commit/868879044e4296f524d6157d37b8601a5fc8dc4d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
suztomo
pushed a commit
that referenced
this pull request
Feb 1, 2023
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrongly typed the default name for deleted topics (d'oh!):
_deleted_topic_should instead be_deleted-topic_. This PR fixes that error and adds a check for thefromPbmethod inTopicId.