Omitting WriteResults for DocumentTransforms #2565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
pongad
reviewed
Nov 7, 2017
| @@ -484,7 +484,7 @@ public String updateCallback(Transaction transaction) { | |||
| @Test | |||
| public void deleteDocument() throws Exception { | |||
| doReturn(beginResponse()) | |||
| .doReturn(commitResponse(0, 0)) | |||
| .doReturn(commitResponse(2, 0)) | |||
The server always returns n write responses for n write requests. The problem is that there is no 1 to 1 mapping between user requests and write requests (some user requests might turn into two writes). This PR removes the extra writes, so that the user can correlate its requests to the responses. |
|
I see. That makes sense. |
pongad
approved these changes
Nov 7, 2017
|
Garrett, please let me know offline if there are any concerns. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to split up a write that contains a ServerTimestamp into two distinct writes. Since the user is unaware of this, we should only return one WriteResult in our response.
This is only relevant for WriteBatches and a port of googleapis/nodejs-firestore#45
I also ran google-java-format on the codebase.