Cleaning up WriteResults #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
schmidt-sebastian
force-pushed
the
mrschmidt-writeresult
branch
from
faac062 to
4f6cea5
Compare
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 11 11
Lines 1464 1470 +6
=====================================
+ Hits 1464 1470 +6
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 11 11
Lines 1464 1470 +6
=====================================
+ Hits 1464 1470 +6
Continue to review full report at Codecov.
|
stephenplusplus
approved these changes
Oct 30, 2017
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two issues with WriteResults:
The return type didn't match the API description. Instead, we returned an object that contained the specified return type inside of it.
When the server returns two responses for one write (due to a server transform), we should only return the first result to the user, since they are unaware of the inner workings.