chore(pubsub): Add pubsub_list_schema_revisions sample #29174
Conversation
| # schema = pubsub.schema "my-schema" | ||
| # schema.list_revisions | ||
| # | ||
| def list_revisions options = {}, view: nil |
There was a problem hiding this comment.
For new methods, please make all "optional" arguments keyword arguments instead of using an "options" hash. The "options" hash pattern is a legacy from older Ruby versions that didn't have good support for keyword arguments.
In particular, it's exceedingly awkward to have an options hash in addition to keyword arguments, because it forces users to do things like this in order to distinguish which keys should go into the options hash vs which should be interpreted as a keyword argument:
my_schema.list_revisions({max: 10, token: "abcde"}, view: "FULL")For this reason, if an existing method already uses an "options" hash, then we should just add new keys to the existing options. But if a method doesn't already have an "options" hash, we should just add keyword arguments and not include an "options" hash at all.
| # * `BASIC` - Include the name and type of the schema, but not the definition. | ||
| # * `FULL` - Include all Schema object fields. | ||
| # | ||
| def list_schema_revisions name, view, options = {} |
There was a problem hiding this comment.
Similarly, use keyword arguments here instead of an "options" hash.
|
Also, this adds an actual new method to the client, not just a sample. So it needs to be a |
b/266094753