-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore(pubsub): Add pubsub_list_schema_revisions sample #29174
Draft
aandreassa
wants to merge
1
commit into
main
Choose a base branch
from
pubsub_list_schema_revisions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -341,6 +341,21 @@ def list_schemas view, options = {} | |
paged_enum.response | ||
end | ||
|
||
## | ||
# Lists all schema revisions for the named schema. | ||
# @param name [String] The name of the schema to list revisions for. | ||
# @param view [String, Symbol, nil] Possible values: | ||
# * `BASIC` - Include the name and type of the schema, but not the definition. | ||
# * `FULL` - Include all Schema object fields. | ||
# | ||
def list_schema_revisions name, view, options = {} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similarly, use keyword arguments here instead of an "options" hash. |
||
schema_view = Google::Cloud::PubSub::V1::SchemaView.const_get view.to_s.upcase | ||
schemas.list_schema_revisions name: name, | ||
view: schema_view, | ||
page_size: options[:max], | ||
page_token: options[:token] | ||
end | ||
|
||
## | ||
# Creates a schema in the current (or given) project. | ||
def create_schema schema_id, type, definition, options = {} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
google-cloud-pubsub/samples/pubsub_list_schema_revisions.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
# Copyright 2025 Google LLC | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
require "google/cloud/pubsub" | ||
|
||
def list_schema_revisions | ||
# [START pubsub_list_schema_revisions] | ||
# schema_id = "your-schema-id" | ||
|
||
pubsub = Google::Cloud::Pubsub.new | ||
|
||
schema = pubsub.schema schema_id | ||
|
||
response = schema.list_revisions | ||
|
||
puts "Listed revisions of schema #{schema_id}" | ||
response.schemas.each do |revision| | ||
puts revision.revision_id | ||
end | ||
# [END pubsub_list_schema_revisions] | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For new methods, please make all "optional" arguments keyword arguments instead of using an "options" hash. The "options" hash pattern is a legacy from older Ruby versions that didn't have good support for keyword arguments.
In particular, it's exceedingly awkward to have an options hash in addition to keyword arguments, because it forces users to do things like this in order to distinguish which keys should go into the options hash vs which should be interpreted as a keyword argument:
For this reason, if an existing method already uses an "options" hash, then we should just add new keys to the existing options. But if a method doesn't already have an "options" hash, we should just add keyword arguments and not include an "options" hash at all.