Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Added example region-tags for row object #266

Merged
merged 8 commits into from
Oct 5, 2018
Merged

Added example region-tags for row object #266

merged 8 commits into from
Oct 5, 2018

Conversation

vijay-qlogic
Copy link
Contributor

Fixes #157 for row.js (it's a good idea to open an issue first for discussion)

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 5, 2018
@codecov
Copy link

codecov bot commented Aug 6, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@6fb4ca7). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #266   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?     10           
  Lines             ?   1281           
  Branches          ?      0           
=======================================
  Hits              ?   1281           
  Misses            ?      0           
  Partials          ?      0
Impacted Files Coverage Δ
src/row.js 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fb4ca7...a16b930. Read the comment docs.

sduskis
sduskis suggested changes Aug 8, 2018
View reviewed changes
samples/document-snippets/row.js
const instance = bigtable.instance(instanceId);
const table = instance.table(tableId);

// [START bigtable_create_rules]

This comment was marked as spam.

# to view

This comment was marked as spam.

# to view

@vijay-qlogic
Copy link
Contributor Author

@sduskis Lint errors are seen due to this commit

Shall I fix it? or 'll be done by @dpebot & I can just pull those change later

@ghost ghost assigned sduskis Aug 10, 2018
@vijay-qlogic vijay-qlogic force-pushed the tag-ex-comments-row branch 2 times, most recently from a0f23b4 to a603d8d Compare August 17, 2018 06:35
@vijay-qlogic vijay-qlogic force-pushed the tag-ex-comments-row branch 2 times, most recently from 7aaad6e to 9b170a5 Compare August 27, 2018 14:37
@vijay-qlogic vijay-qlogic force-pushed the tag-ex-comments-row branch 2 times, most recently from 21a64f6 to ee8fd2e Compare August 31, 2018 17:32
@sduskis sduskis merged commit 58457b7 into googleapis:master Oct 5, 2018
@snyk-bot snyk-bot mentioned this pull request Mar 4, 2020
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sduskis sduskis sduskis approved these changes

Assignees

@sduskis sduskis

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vijay-qlogic @sduskis @googlebot