-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[tempo-distributed] Allow prefixing of rollout-group value and ingester name #3443
base: main
Are you sure you want to change the base?
[tempo-distributed] Allow prefixing of rollout-group value and ingester name #3443
Conversation
dbba1fc
to
e19aa4e
Compare
c82231a
to
a975fa1
Compare
a975fa1
to
3901a73
Compare
62fda25
to
ca4e7c7
Compare
ca4e7c7
to
9fdf4d9
Compare
Signed-off-by: Brian Oldfield <boldfield@nvidia.com>
Signed-off-by: Brian Oldfield <boldfield@nvidia.com>
Signed-off-by: Brian Oldfield <boldfield@nvidia.com>
9fdf4d9
to
b539ef7
Compare
The corollary of this PR for the Loki charts has been merged: grafana/loki#15063 |
I'm concerned about the complexity this adds to the chart. I would strongly advise not running both Loki and Tempo in the same namespace. Is there a reason to put them in one? |
@joe-elliott we have constraints within our environment that require running the entire LTGM stack in a single namespace and are actively doing it. These changes are opt-in so they will not add additional complexity w/r to users who do not opt to use the feature. |
I also have an alternative solution that can be found here: grafana/rollout-operator#190 |
Hi @joe-elliott, any additional thoughts here? The alternative approach was nixed and kustomize isn't an option for us. Thanks. |
Brian - can you provide any more information here about why a single namespace is needed? thanks |
Allow for prefixing both the
rollout-group
label,name
label, and serviceName of the Tempo Ingester StatefulSet, when running in distributed mode, to avoid scheduling and rollout issues when deploying multiple elements of the LTGM stack to a single namespace.Fixes #3442