chore: Setup release-please #933
Conversation
Sets a minimal configuration for release-please to only handle feat, fix, and docs commits. Other categories might be included in the future if considered necessary.
This type only exists to allow forcing release-please PR generation when the commits from the previous release are all internal (none of them comply with the supported sections by the release-please configuration). The convention is to push a single empty commit with message: `release: Internal release` Which will indicate that that release only contains internal changes.
There was a problem hiding this comment.
This is amazing! It will simplify a lot of manual tasks, so thanks a lot for setting it up! 🚀🚀🚀
The only thing I think is missing is some docs describing how the process would work (in particular, for the frontend app) from now on after this PR (and #947) are merged. Apologies if it's already created and I didn't see it.
| { "type": "chore", "section": "Miscellaneous Chores" }, | ||
| { "type": "refactor", "section": "Code Refactoring" }, |
There was a problem hiding this comment.
We also use chore and refactor, so we might wanna add them as well.
There was a problem hiding this comment.
Ah I missed this, I thought these were not being included in the changelog/release notes. Since you are already using these in your workflow and are included in the release I think it makes sense to add them in this case and not break the current "pattern". See d2c69a1.
| on: | ||
| push: | ||
| branches: | ||
| - main |
There was a problem hiding this comment.
So, merging to main will always trigger the release, is that right?
There was a problem hiding this comment.
Ah apologies, I should have linked here the actual process definition, you can see it in https://github.com/grafana/deployment_tools/pull/177384, this is the part specifically for the app here. I'll appreciate any comment that you have on that PR too.
These types are already being used in the workflow for the app and included in the changelog and release notes, therefore it makes sense to keep supporting them and not break the current pattern.
What this PR does / why we need it:
Sets up release-please GH action.
Which issue(s) this PR fixes:
Updates grafana/synthetic-monitoring/issues/50