Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: Tune release process #947

Merged
merged 2 commits into from
Oct 7, 2024
Merged

chore: Tune release process #947

merged 2 commits into from
Oct 7, 2024

Conversation

ka3de
Copy link
Contributor

@ka3de ka3de commented Sep 27, 2024

What this PR does / why we need it:
Modifies the release process in order to be compatible with the usage of release-please and avoid some current manual steps.

Specifically:

  • Removes the tag and release generation when promoting build to production, as that should now be done by release-please when merging the version PR.
  • Modifies the configuration for the deployment tools PR when promoting to production so it is automatically merged (the same way it's done for staging) instead of requiring a manual approval from reviewers.

Updates https://github.com/grafana/synthetic-monitoring/issues/50.

This should now be done by release-please.
Modifies the promote to production pipeline to auto merge the PR that is
performed to update the plugin in deployment tools, the same way it is
done for staging environment.
@ka3de ka3de marked this pull request as ready for review October 2, 2024 08:17
@ka3de ka3de requested a review from a team as a code owner October 2, 2024 08:17
@ka3de ka3de requested a review from ckbedwell October 2, 2024 08:17
@ckbedwell ckbedwell requested review from VikaCep and w1kman October 3, 2024 14:35
@ka3de
Copy link
Contributor Author

ka3de commented Oct 3, 2024

To give a little bit more context to other reviewers. This PR is the result of a discussion held with @ckbedwell on how to improve the release process for the app, particularly how to avoid some manual steps, and also how to make it compatible with the usage of release-please (see #933). See the original discussion document.
I applied the changes based on the discussion in that document and my understanding of the app's CI/CD, but I think the simplest approach might be to merge this after #933, try generating a release, and revert It if It does not work 😅

@ka3de ka3de merged commit 1b3f2c0 into main Oct 7, 2024
4 of 5 checks passed
@ka3de ka3de deleted the tune-release-process branch October 7, 2024 12:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants