Skip to content
This repository has been archived by the owner on Jan 30, 2025. It is now read-only.

Remove goja from newPointerAction #1217

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Remove goja from newPointerAction #1217

merged 1 commit into from
Feb 16, 2024

Conversation

inancgumus
Copy link
Member

@inancgumus inancgumus commented Feb 16, 2024 •
edited
Loading

What?

  • Degojafies offsetPosition.
  • Frame and ElementHandle no longer depend on Goja while doing newPointerActions.

Why?

Stability.

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

Updates: #1170

@inancgumus
Remove goja from newPointerAction
0d9446c 
offsetPosition is the only one using Goja. Removed.
@inancgumus inancgumus self-assigned this Feb 16, 2024
@inancgumus inancgumus mentioned this pull request Feb 16, 2024
Closed
@inancgumus inancgumus requested a review from ankur22 February 16, 2024 08:29
@inancgumus inancgumus added refactor bug Something isn't working labels Feb 16, 2024
@inancgumus inancgumus merged commit 69e1f33 into main Feb 16, 2024
17 checks passed
@inancgumus inancgumus deleted the refactor/degojafy-newPointerAction branch February 16, 2024 09:39
@inancgumus inancgumus mentioned this pull request Feb 16, 2024
Merged
@BrewTestBot BrewTestBot mentioned this pull request Mar 25, 2024
Merged
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@ankur22 ankur22 ankur22 approved these changes

Assignees

@inancgumus inancgumus

Labels
bug Something isn't working refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inancgumus @ankur22