Skip to content
This repository has been archived by the owner on Jan 30, 2025. It is now read-only.

Remove goja from newPointerAction #1217

Merged
merged 1 commit into from
Feb 16, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 2 additions & 14 deletions common/element_handle.go
Original file line number Diff line number Diff line change
Expand Up @@ -399,21 +399,9 @@ func (h *ElementHandle) offsetPosition(apiCtx context.Context, offset *Position)
return nil, err
}

rt := h.execCtx.vu.Runtime()
var border struct{ Top, Left float64 }
switch result := result.(type) {
case goja.Value:
if result != nil && !goja.IsUndefined(result) && !goja.IsNull(result) {
obj := result.ToObject(rt)
for _, k := range obj.Keys() {
switch k {
case "left":
border.Left = obj.Get(k).ToFloat()
case "top":
border.Top = obj.Get(k).ToFloat()
}
}
}
if err := convert(result, &border); err != nil {
return nil, fmt.Errorf("converting result (%v of type %t) to border: %w", result, result, err)
}

box := h.BoundingBox()
Expand Down
Loading