Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added removeRoles function that removes all existing UserRoles for th… #90

Closed
wants to merge 1 commit into from

Conversation

alexbulyha
Copy link

Added removeRoles function that removes all existing UserRoles for the provided user that are not in the given list of roles. Replaced removing all roles for userUpdate. Added check for addRoles, if the user role already exists

#89

…e provided user that are not in the given list of roles. Replaced removing all roles for userUpdate. Added check for addRoles, if the user role already exists
ddelponte added a commit that referenced this pull request May 3, 2018
• fixed bug in `SpringSecurityUiService` that was removing all of a `User`'s `Role` associations upon user update
•• inspiration was taken from the PR at #90
• fixed bug where, if all `Role`s were unchecked for a `User`, after update, no roles would be displayed
• modified test to support change to support change to `Role` display
@ddelponte
Copy link
Collaborator

@AlexBoulyga thank-you so much for this PR!

I've used this PR for inspiration and created a new one at #95

I've also verified that User updates work with this PR ☝️ and included an additional bug fix.

Thanks again!

@ddelponte ddelponte closed this May 3, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants