issue 89: User update removes all user roles #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• fixed bug in `SpringSecurityUiService` that was removing all of a `User`'s `Role` associations upon user update •• inspiration was taken from the PR at #90 • fixed bug where, if all `Role`s were unchecked for a `User`, after update, no roles would be displayed • modified test to support change to support change to `Role` display
This was referenced May 3, 2018
|
@ddelponte could we have a test which verifies this issue? |
- Added `webdrivermanager` dependency which will automatically download the chrome driver if it doesn't exist on the test machine - Modified simple integration `UserSpec` test to verify the fix for Issue #89
|
@sdelamo I think this may be ready for merge |
- Add Feature #49 - Add ability to have multiple security questions. - Remove Rogue Import - Fix loader for tests - Update Chrome Driver - Make it so the example has the new files that go the up - Fix the test and add an example of not using email. - Fix items from Code Review - Make it so the extended plugin actually works. - Documentation updates and a quick refactor - Update YML File so the test pass - saving the fuzzy search - Added the listener to hash the Security Answers to use the same strategy as the password encoding. - Removed multiple domain based validations - Fixed tests - Fix YML file - Create Scripts - Added the Security Questions to the Menu - Make the grails version the same as the example projects - Finish Creating Script to setup security questions - Add a check for a when a user doesn't have secuirty questions setup - Add an entry in the Menu if this feature is turned on. - Clean up the script to take the user name package and class name - Make the Security Questions not dependent on Scaffolding. - Create the Script to add all the security questions - Make the Security Questions not dependent on Scaffolding. - Create the Script to add all the security questions - Make the file names/scripts and documentation all have the same name of challenge questions by default - Make the file names/scripts and documentation all have the same name of challenge questions by default - Updated Documentation and all names to match and consistent in the application. - Fixed Code Review items - Fixed Bugs with script creation - Fixed Code back to normal from testing - Account for when the User that is passed in the script doesn't contain the package - Add some more documentation around the user-domain-class-name parameter in the script. - Update ChallengeQuestionsListenerService.groovy.template - Remove Unused Import - Update ProfileListenerService.groovy
|
@sdelamo conflicts have been resolved. I think this is ready to merge |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpringSecurityUiServicethat was removing all of aUser'sRoleassociations upon user updateRoles were unchecked for aUser, after update, no roles would be displayedRoledisplayThis PR is for issue #89