Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Only acquire semaphore lease if maxconnections is configured #12462

Merged
merged 8 commits into from
May 5, 2022
Merged

Only acquire semaphore lease if maxconnections is configured #12462

merged 8 commits into from
May 5, 2022

Conversation

xacrimon
Copy link
Contributor

@xacrimon xacrimon commented May 5, 2022

Fixes #12459

r0mant
r0mant reviewed May 5, 2022
View reviewed changes
Copy link
Collaborator

@r0mant r0mant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xacrimon In addition to testing manually, let's please add test coverage to make sure it does not regress again.

@xacrimon xacrimon requested a review from r0mant May 5, 2022 16:10
@xacrimon xacrimon marked this pull request as ready for review May 5, 2022 16:10
@xacrimon xacrimon requested a review from r0mant May 5, 2022 16:30
@xacrimon xacrimon enabled auto-merge (squash) May 5, 2022 17:05
@xacrimon xacrimon disabled auto-merge May 5, 2022 17:09
ibeckermayer
ibeckermayer approved these changes May 5, 2022
View reviewed changes
@xacrimon xacrimon enabled auto-merge (squash) May 5, 2022 17:21
@xacrimon xacrimon merged commit 3120876 into master May 5, 2022
@github-actions
Copy link

github-actions bot commented May 5, 2022

@xacrimon See the table below for backport results.

Branch Result
branch/v9 Failed

xacrimon added a commit that referenced this pull request May 5, 2022
@xacrimon
Only acquire semaphore lease if maxconnections is configured (#12462)
19afb93
@xacrimon xacrimon mentioned this pull request May 5, 2022
Merged
r0mant added a commit that referenced this pull request May 5, 2022
@xacrimon @r0mant
Only acquire semaphore lease if maxconnections is configured (#12462) (…
883ccd5 
…#12468)

Co-authored-by: Roman Tkachenko <roman@goteleport.com>
@webvictim webvictim mentioned this pull request Jun 8, 2022
Closed
@zmb3 zmb3 mentioned this pull request Jun 21, 2022
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@r0mant r0mant r0mant approved these changes

@zmb3 zmb3 zmb3 left review comments

@ibeckermayer ibeckermayer ibeckermayer approved these changes

@rosstimothy rosstimothy rosstimothy approved these changes

Assignees
No one assigned
Labels
backport-required kubernetes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port forwarding doesn't work for kubernetes
5 participants
@xacrimon @r0mant @zmb3 @ibeckermayer @rosstimothy