Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Only acquire semaphore lease if maxconnections is configured #12462

Merged
merged 8 commits into from
May 5, 2022
Merged

Only acquire semaphore lease if maxconnections is configured #12462

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5aeb01b
Only acquire semaphore lease if maxconnections is configured
xacrimon May 5, 2022
1e2a620
Add limit tests
xacrimon May 5, 2022
e336a60
Remove test that the new one supercedes
xacrimon May 5, 2022
b96c7b8
move test to proxy pkg
xacrimon May 5, 2022
dc67a0d
remove noop conversion
xacrimon May 5, 2022
bff406c
Merge branch 'master' into joel/only-set-lease-if-nonzero
xacrimon May 5, 2022
62a2856
remove unused field
xacrimon May 5, 2022
a0f2578
feedback
xacrimon May 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/kube/proxy/forwarder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -908,6 +908,10 @@ func (f *Forwarder) acquireConnectionLock(ctx context.Context, identity *authCon
}

maxConnections := services.RoleSet(roles).MaxKubernetesConnections()
if maxConnections == 0 {
return nil
}

semLock, err := services.AcquireSemaphoreLock(ctx, services.SemaphoreLockConfig{
Service: f.cfg.AuthClient,
Expiry: sessionMaxLifetime,
Expand Down