-
Notifications
You must be signed in to change notification settings - Fork 12
feat: allow using "next" version on supported version #58
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5cddd5c
to
a6bf3b3
Compare
ihor-sviziev
approved these changes
Sep 29, 2022
ihor-sviziev
approved these changes
Oct 3, 2022
ihor-sviziev
approved these changes
Oct 4, 2022
…ded (#68) This allows using the action in https://github.com/mage-os/generate-mirror-repo-js where the test module is an external package installed with composer. In this case, no local path repo configuration is needed.
a830f8a
to
a3be6b2
Compare
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, we don't specify what versions to use if you're planning on using nightly builds of the Magento 2 codebase (for example MageOS).
Fixes: mage-os/generate-mirror-repo-js#24
What is the new behavior?
We now specify a composite key called
magento/project-community-edition:next
which contains the versions supposed to be used by upstream. This key can also serve as a sort of warrant canary for the community on when backwards incompatible changes are coming.Does this PR introduce a breaking change?
Other information