Bump the grpc release version to v1.2.0 #475
Conversation
mehrdada
changed the title
mehrdada
changed the title
There was a problem hiding this comment.
Actually, the right person to review might by @stanley-cheung, I think he was involved in setting up the branch-switching logic for grpc.io.
_data/config.yml
Outdated
| @@ -1,3 +1,3 @@ | |||
| grpc_release_branch: v1.0.0 | |||
| grpc_release_branch: v1.2.0 | |||
| grpc_java_release_tag: v1.0.3 | |||
| @@ -1,3 +1,3 @@ | |||
| grpc_release_branch: v1.0.0 | |||
There was a problem hiding this comment.
btw, v1.0.0 is actually a tag, not a branch, but I guess it's just the naming that wrong.
There was a problem hiding this comment.
I am reluctant to changing it in this tiny commit as it is referenced in a dozen places and might need more thought and knowledge of project history.
There was a problem hiding this comment.
So this value of this variable goes into link like this:
"https://github.com/grpc/grpc/blob/v1.2.0/examples/protos/route_guide.proto"
So as long as it can go after the /blob/ part of the github URL that works. And tags work in that part of the URL. So yes the variable naming might be a bit off (both branch name and tag name can go after /blob/) but we can continue with this update.
jtattermusch
requested review from
stanley-cheung
and removed request for
ctiller and
stanley-cheung
|
Added @stanley-cheung and removed Craig and myself. |
mehrdada
force-pushed
the
bump-slash-release-version-to-v1.1.0
branch
from
fc6e85e to
57085e5
Compare
Our guides often ask the user to issue a git clone command which checkouts a branch specified in grpc.io/release URL. It is critical that the release version gets updated as we ship new versions. This patch bumps it from 1.0.0 to 1.2.0.
|
@stanley-cheung friendly ping. |
Our guides often ask the user to issue a git
clone command which checkouts a branch specified
in grpc.io/release URL. It is critical that the
release version gets updated as we ship new
versions. This patch bumps it from 1.0.0 to
1.2.0.
(c.f. #471)