Skip to content
This repository was archived by the owner on Apr 9, 2021. It is now read-only.

Bump the grpc release version to v1.2.0 #475

Merged
merged 1 commit into from
Mar 25, 2017
Merged

Bump the grpc release version to v1.2.0 #475

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions _data/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
grpc_release_branch: v1.0.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, v1.0.0 is actually a tag, not a branch, but I guess it's just the naming that wrong.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am reluctant to changing it in this tiny commit as it is referenced in a dozen places and might need more thought and knowledge of project history.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this value of this variable goes into link like this:

"https://github.com/grpc/grpc/blob/v1.2.0/examples/protos/route_guide.proto"

So as long as it can go after the /blob/ part of the github URL that works. And tags work in that part of the URL. So yes the variable naming might be a bit off (both branch name and tag name can go after /blob/) but we can continue with this update.

grpc_java_release_tag: v1.0.3
grpc_release_branch: v1.2.0
grpc_java_release_tag: v1.2.0
milestones_link: https://github.com/grpc/grpc/milestones