Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update GdkPixbuf gir files #72

Merged
merged 2 commits into from
Jan 3, 2021
Merged

Update GdkPixbuf gir files #72

merged 2 commits into from
Jan 3, 2021

Conversation

pbor
Copy link

@pbor pbor commented Jan 2, 2021

@sdroege
Copy link
Member

sdroege commented Jan 2, 2021

Please run fix.sh. That should also fix up the formatting :)

@pbor
Copy link
Author

pbor commented Jan 2, 2021

fix.sh did not do anything, but reformat.sh did the trick :)

sdroege
sdroege approved these changes Jan 2, 2021
View reviewed changes
Copy link
Member

@sdroege sdroege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Ideally you'd first check if the gdk-pixbuf-sys and non-sys` can be generated properly from this and the changes make sense.

Can you create a WIP PR for that based on these .gir files? If no further fixes are needed this can get in then.

pbor pushed a commit to pbor/gtk-rs that referenced this pull request Jan 3, 2021
WIP: uddate GdkPixbuf
0e772be 
Shows the generated files if gtk-rs/gir-files#72
is merged
@pbor pbor mentioned this pull request Jan 3, 2021
Merged
@pbor
Copy link
Author

pbor commented Jan 3, 2021

It seems to choke on gmodule... I added GModule to external_libraries in Gir.toml, but that does not seems to be enough...

pbor pushed a commit to pbor/gtk-rs that referenced this pull request Jan 3, 2021
WIP: uddate GdkPixbuf
af8593f 
Shows the generated files if gtk-rs/gir-files#72
is merged
pbor pushed a commit to pbor/gtk-rs that referenced this pull request Jan 3, 2021
WIP: uddate GdkPixbuf
7aa6adf 
Shows the generated files if gtk-rs/gir-files#72
is merged
pbor pushed a commit to pbor/gtk-rs that referenced this pull request Jan 3, 2021
WIP: uddate GdkPixbuf
5cf7ee3 
Shows the generated files if gtk-rs/gir-files#72
is merged
@sdroege sdroege merged commit 824aa87 into gtk-rs:master Jan 3, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sdroege sdroege sdroege approved these changes

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pbor @sdroege @GuillaumeGomez